Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): deduplicate yarn cache by removing the set-up-job action #8504

Merged
merged 3 commits into from
Jun 3, 2023
Merged

chore(ci): deduplicate yarn cache by removing the set-up-job action #8504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22c550f
chore(ci): remove set up job action
jtoar Jun 3, 2023
c1a5b0d
Merge branch 'main' into ds-ci/rm-set-up-job
jtoar Jun 3, 2023
640afc0
same for canary release workflows
jtoar Jun 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions .github/actions/set-up-job/action.yml
View file
Open in desktop

This file was deleted.

63 changes: 53 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,16 @@ jobs:
steps:
- uses: actions/checkout@v3

- uses: actions/setup-node@v3
- name: ⬢ Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 18

- run: yarn install
- name: 🐈 Yarn install
working-directory: ./.github/actions/only_doc_changes
run: yarn install --inline-builds
env:
GITHUB_TOKEN: ${{ github.token }}

- name: 📖 Only doc changes?
id: only-doc-changes
Expand All @@ -40,11 +44,17 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3

- name: ⬢ Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 18
- run: yarn install

- name: 🐈 Yarn install
working-directory: ./tasks/check
run: yarn install --inline-builds
env:
GITHUB_TOKEN: ${{ github.token }}

- name: ✅ Check constraints, dependencies, and package.json's
uses: ./tasks/check
Expand All @@ -71,8 +81,19 @@ jobs:
run: echo "echo "::remove-matcher owner=tsc::""

- uses: actions/checkout@v3
- name: 🧶 Set up job
uses: ./.github/actions/set-up-job

- name: ⬢ Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 18

- name: 🐈 Set up yarn cache
uses: ./.github/actions/set-up-yarn-cache

- name: 🐈 Yarn install
run: yarn install --inline-builds
env:
GITHUB_TOKEN: ${{ github.token }}

- name: 🔨 Build
run: yarn build
Expand Down Expand Up @@ -109,8 +130,19 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- name: 🧶 Set up job
uses: ./.github/actions/set-up-job

- name: ⬢ Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 18

- name: 🐈 Set up yarn cache
uses: ./.github/actions/set-up-yarn-cache

- name: 🐈 Yarn install
run: yarn install --inline-builds
env:
GITHUB_TOKEN: ${{ github.token }}

- name: 📁 Create a temporary directory
id: createpath
Expand Down Expand Up @@ -378,8 +410,19 @@ jobs:
REDWOOD_REDIRECT_TELEMETRY: "http://127.0.0.1:48619" # Random port
steps:
- uses: actions/checkout@v3
- name: 🧶 Set up job
uses: ./.github/actions/set-up-job

- name: ⬢ Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 18

- name: 🐈 Set up yarn cache
uses: ./.github/actions/set-up-yarn-cache

- name: 🐈 Yarn install
run: yarn install --inline-builds
env:
GITHUB_TOKEN: ${{ github.token }}

- name: 🔨 Build
run: yarn build
Expand Down
14 changes: 12 additions & 2 deletions .github/workflows/publish-canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,18 @@ jobs:
with:
fetch-depth: 0

- name: 🧶 Set up job
uses: ./.github/actions/set-up-job
- name: ⬢ Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 18

- name: 🐈 Set up yarn cache
uses: ./.github/actions/set-up-yarn-cache

- name: 🐈 Yarn install
run: yarn install --inline-builds
env:
GITHUB_TOKEN: ${{ github.token }}

- name: ✅ Check constraints, dependencies, and package.json's
uses: ./tasks/check
Expand Down
14 changes: 12 additions & 2 deletions .github/workflows/publish-release-candidate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,18 @@ jobs:
# This is required because lerna uses tags to determine the version.
fetch-depth: 0

- name: 🧶 Set up job
uses: ./.github/actions/set-up-job
- name: ⬢ Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 18

- name: 🐈 Set up yarn cache
uses: ./.github/actions/set-up-yarn-cache

- name: 🐈 Yarn install
run: yarn install --inline-builds
env:
GITHUB_TOKEN: ${{ github.token }}

- name: ✅ Check constraints, dependencies, and package.json's
uses: ./tasks/check
Expand Down