Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crwa): Prevent links including "zero width space" in URL #8226

Merged
merged 1 commit into from
May 5, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM commented May 5, 2023

Fixes #8224

Problem
When using some terminals the "zero width space" is included in the URL link and causes a 404 when trying to access the link.

Solution
As per sindresorhus/terminal-link#18 the solution is to add a fallback with the text formatted as we'd like it to be presented.

Using Hyper the output looks like:
image
FYI: I did try text (url) but it picked up the ) in the url.

@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label May 5, 2023
@Josh-Walker-GM Josh-Walker-GM requested a review from jtoar May 5, 2023 00:56
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test locally on hyper, works great, thanks @Josh-Walker-GM!

@jtoar jtoar merged commit 946c705 into main May 5, 2023
@jtoar jtoar deleted the jgmw-crwa/link-fix branch May 5, 2023 02:47
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone May 5, 2023
@jtoar jtoar modified the milestones: next-release, next-release-patch May 5, 2023
jtoar pushed a commit that referenced this pull request May 5, 2023
@jtoar jtoar modified the milestones: next-release-patch, v5.0.5 May 5, 2023
jtoar pushed a commit that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Compatibility Check Error Message with the wrong link (Page Not Found error)
2 participants