Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telemetry): Avoid getConfig for CRWA #7621

Merged
merged 2 commits into from
Feb 13, 2023
Merged

fix(telemetry): Avoid getConfig for CRWA #7621

merged 2 commits into from
Feb 13, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM commented Feb 11, 2023

Problem

  1. Calling getConfig which is needed to test for the web bundler option breaks telemetry when it is run for create-redwood-app.
  2. The telemetry ID cache file was not being created when running create-redwood-app.

Changes

  1. Default to webpack for crwa telemetry and call getConfig for any other case.
  2. Create the .redwood directory if it does not exist when trying to write the telemetry cache file.

Ping
@jtoar, @thedavidprice - the fix.
@dac09 - I tested and this still sends the vite bundler option when I enabled it on a new project. If suddenly the data stops let me know in case I've broken it in a more subtle way.

@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label Feb 11, 2023
@dac09
Copy link
Contributor

dac09 commented Feb 12, 2023

Yo sorry about breaking this, and thanks for the fix Josh!

@dac09 dac09 merged commit 2ecb490 into main Feb 13, 2023
@dac09 dac09 deleted the jgmw-telemetry-fix branch February 13, 2023 05:53
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Feb 13, 2023
jtoar pushed a commit that referenced this pull request Feb 13, 2023
jtoar pushed a commit that referenced this pull request Feb 13, 2023
jtoar pushed a commit that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants