Label override flags for dbAuth generator #7118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![redwoodjs-bot[bot]](https://avatars.githubusercontent.com/in/121504?s=60&v=4){kind=small}
* initial ability to pass label arguements * Added remaining parameters to auth template files * Added no default value check in order to pass tests * Apply suggestions: reduce templateVars duplication Co-authored-by: Tobbe Lundberg <[email protected]> * Apply suggestions: replace ternary Co-authored-by: Tobbe Lundberg <[email protected]> * Added missing templateVars declaration * Renamed template vars * Renamed flags to include 'label', added prompts and used listr2 tasks for user interrogation * Updated yarn.lock * Added default values within function * Updated web authn page template - not tested * Moved WebAuthn into listr * Some tidying up * Fix default webauthn flag value check * Added enquirer option and other minor fixes * Added tests for prompts * Add web.app to the mocked getPaths * Fix password label and add listr2 options to task handler * Added snapshot tests * Added --username-label and --password-label flags to the docs for rw g dbAuth * Normalise paths within tests * Added test for custom labels and webauthn enabled * Add flags to prevent test project creation prompting the user * Updated test project fixtures * update snapshots and set mockfiles before test describe * Customised auth variables similar to labels * updated test fixtures * Update test snapshots * Updated to use customised variable names based on label option * Add missing dbAuth command test Co-authored-by: Tobbe Lundberg <[email protected]> Co-authored-by: Rob Cameron <[email protected]>
redwoodjs-bot
bot
added
cherry-pick
release:feature
jtoar
deleted the
cherry-pick-next-21b6b51dd0e38d5891da1fed8e7c8ffefcdc3d8d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3555
Description
Adds optional flags
username-labelandpassword-labelwhich set the form labels in theSignupPage,LoginPage,ForgotPasswordPageandResetPasswordPagegenerated via theyarn rw g dbAuthcommand.Adds prompts to get these labels from the user if not already passed in by the flags. Prompt default values are
UsernameandPasswordExample of the CLI prompting:
These label values are also used to determine the name of the variables within the generated files. This means if you request that
username-labelbeemailthen variables likeusernameRefbecomeemailRef. Thanks to @Tobbe for this good idea!Outstanding