Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]: Fix and rebuild test project fixture #6775

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Nov 2, 2022

@virtuoushub reported that rebuilding the test project fixture with yarn build:test-project --rebuild-fixture on #4992 was broken. Turns out it was also broken on main, I think for reasons similar to #6772. This PR adds a step to recopy the framework code after generating the scaffold, and rebuilds the text project fixture cause it works now.

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Nov 2, 2022
@jtoar jtoar self-assigned this Nov 2, 2022
Copy link
Collaborator

@virtuoushub virtuoushub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in chore/upgrade-to-react-18 ( see: a4fb4f3 )

@jtoar jtoar merged commit 4d506cd into main Nov 2, 2022
@jtoar jtoar deleted the ds-fix-rebuild-test-project-fixture branch November 2, 2022 18:32
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Nov 2, 2022
@redwoodjs-bot
Copy link

redwoodjs-bot bot commented Nov 2, 2022

🔔 @jtoar, @Tobbe—I couldn't cherry pick this one. If you want it in the next release, you'll have to cherry pick it manually.

@jtoar jtoar modified the milestones: next-release, v3.4.0 Nov 3, 2022
dac09 added a commit that referenced this pull request Nov 7, 2022
…aching

* 'main' of github.com:redwoodjs/redwood: (21 commits)
  [Tutorial]: Fix Typescript code blocks inconsistency (#6801)
  chore: update all contributors
  Custom auth: Fix comment in template (#6804)
  fix(deps): update dependency eslint to v8.26.0 (#6785)
  [CRWA]: Switch to using enquirer, add engine compatibility override option (#6723)
  (docs): Minor Command update about Storybook (#6722)
  docs: Add mocking useLocation to docs (#6791)
  Update generated render.yaml (#6771)
  fix flightcontrol config template (#6789)
  fix: publish canary using premajor (#6794)
  Strip resetToken and resetTokenExpiresAt from dbAuth forgotPassword handler (#6778)
  Fix WebAuthn when event body is base64 encoded (like when deploying to Vercel) (#6757)
  fix(deps): update jest monorepo (#6787)
  fix(deps): update dependency react-hook-form to v7.39.1 (#6786)
  fix(deps): update dependency fastify to v4.9.2 (#6781)
  fix(deps): update dependency @apollo/client to v3.7.1 (#6780)
  chore: fix and rebuild test project fixture (#6775)
  fix: add prisma resolutions to tutorial e2e test proj (#6772)
  fix(deps): update prisma monorepo to v4.5.0 (#6485)
  Fix dbauth webauthn template (redundant type import) (#6769)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants