Update Clerk import in decoder

[stephenhandley]

We ran into the following error when trying to use Clerk with Redwood.

api | 16:37:43 🚨 graphql-server Error building context. Error: Exception in getAuthenticationContext: Cannot find module './dist/instance'
api | Require stack:
api | - PROJECT_DIR/node_modules/@clerk/clerk-sdk-node/instance.js
api | - PROJECT_DI/node_modules/@redwoodjs/api/dist/auth/decoders/clerk.js
api | - PROJECT_DIR/node_modules/@redwoodjs/api/dist/auth/decoders/index.js
api | - PROJECT_DIR/node_modules/@redwoodjs/api/dist/auth/index.js
api | - PROJECT_DIR/node_modules/@redwoodjs/api/dist/index.js
api | - PROJECT_DIR/node_modules/@redwoodjs/graphql-server/dist/functions/graphql.js
api | - PROJECT_DIR/node_modules/@redwoodjs/graphql-server/dist/index.js
api | - PROJECT_DIR/api/dist/functions/graphql.

We had a dep of @clerk/clerk-sdk-node of 4.4.0

I believe what was at issue are the following lines in the decoder:
https://github.com/redwoodjs/redwood/blame/main/packages/api/src/auth/decoders/clerk.ts#L5-L7

const Clerk = require('@clerk/clerk-sdk-node/instance').default

const { users, base }: IClerk = new Clerk()

Clerk version 4.4.0 no longer has a dist/instance.js file instead there are dist/esm/instance.js and dist/cjs/instance.js files. they also now just export a singleton on the default. Changing the above lines to the following fixed things for us locally

const { users, base } = require('@clerk/clerk-sdk-node').default

[noire-munich]

@stephenhandley good to see you!
Many thanks for taking the time to make a PR on this, we shall look into it.

[stephenhandley]

Awesome thanks @noire-munich good to see you too!

[replay-io]

10 replays were recorded for 74a5b42.

0 Failed

10 Passed

• requireAuth graphql checks
• useAuth hook, auth redirects checks
• RBAC: Admin user should be able to delete contacts
• RBAC: Should not be able to delete contact as non-admin user
• Smoke test with dev server
• Smoke test with rw serve
• Loads Cell mocks when Cell is nested in another story
• Loads Cell Stories
• Loads MDX Stories
• Mocks current user, and updates UI while dev server is running

View test run on Replay ↗︎

[Tobbe]

Just a heads up here 🙂 I merged #5985 about an hour ago. The clerk decoder now lives in https://github.com/redwoodjs/redwood/blob/main/packages/auth-providers-api/src/clerk/decoder.ts

[noire-munich]

Since decoupled auth has been merged the file has changed location, please check this comment
#6685 (comment)

[stephenhandley]

@noire-munich @Tobbe ok just moved the changes to the new file path

[Tobbe]

We also have this PR that seems to be making a similar change. Which one should we go with? #6719

[stephenhandley]

@Tobbe good thing from that PR missing from mine is all the bumped deps, however the implementation in the decoder looks a lot more brittle with the use of the instance paths.

[noire-munich]

@stephenhandley I'm holding my approval until either this PR or this one gets everything we feel we'd need.
I'd opt for your implementation of not using the instance paths, but @SokratisVidros being the founding engineer of Clerk I'm interested into knowing why he's using it.

[SokratisVidros]

@stephenhandley Thanks for submitting this.

@noire-munich The PRs are basically the same, fixing a backward incompatible change we made in @clerk/clerk-sdk-node.

You can merge either of them.

[MehdiSv]

@noire-munich Any update on this? We'd love to be able to use the latest version of Clerk with Redwood.

[alephao]

@noire-munich can we just approve this one then, it seems @SokratisVidros is fine with it and it doesn't use instance paths

[noire-munich]

@stephenhandley I've approved this, if you'd like to bump before we merge it would be great, otherwise we'll use the other PR for that.

[SokratisVidros]

Cool. I am closing mine.

[SokratisVidros]

Can we merge?

[Tobbe]

I've confirmed that this fixes the require call for the decoder. Still seems like we have a problem with our Clerk implementation though. I'll try to merge this PR, and then I'll submit a new PR for fixing the new issue I found. (Navigating to a page that requires that you're logged in prints "Please wrap your auth provider with <ClerkLoaded>" in the console and just redirects you back to the home page. We do wrap our router in <ClerkLoaded>