Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy): added windows fix for nodeFileTrace when deploying to serverless #6325

Merged
merged 8 commits into from
Sep 5, 2022
Merged

fix(deploy): added windows fix for nodeFileTrace when deploying to serverless #6325

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0ff6d8d
issue#5852 added windows fix for nodeFileTrace
IThinkThatsKirby Aug 30, 2022
0a7d666
Update packages/internal/src/build/api.ts
IThinkThatsKirby Aug 30, 2022
97686f0
Update packages/internal/src/build/web.ts
IThinkThatsKirby Aug 30, 2022
b229777
issue# 5852 now only the import files are changed.
IThinkThatsKirby Aug 31, 2022
284cac4
issue #5852 only import files changed.
IThinkThatsKirby Aug 31, 2022
236f898
Merge branch 'redwoodjs:main' into ittk-5852-windows-sls-deploy
IThinkThatsKirby Sep 5, 2022
6db43cc
Adds test for src-alias plugin - unlikely to work on Windows
dac09 Sep 5, 2022
20f605e
Merge branch 'main' into ittk-5852-windows-sls-deploy
dac09 Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/internal/src/build/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,16 @@ export const prebuildApiFiles = (srcFiles: string[]) => {
return undefined
}

// Fixes nodeFileTrace errors on windows when building
let nodeFileTraceCompliantCode: string = result.code
if (process.platform === 'win32') {
nodeFileTraceCompliantCode = nodeFileTraceCompliantCode.replaceAll(
'\\\\',
'/'
)
}
fs.mkdirSync(path.dirname(dstPath), { recursive: true })
fs.writeFileSync(dstPath, result.code)
fs.writeFileSync(dstPath, nodeFileTraceCompliantCode)

return dstPath
})
Expand Down
10 changes: 9 additions & 1 deletion packages/internal/src/build/web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,16 @@ export const prebuildWebFiles = (srcFiles: string[], flags?: Flags) => {
return undefined
}

// Fixes nodeFileTrace errors on windows when building
let nodeFileTraceCompliantCode: string = result.code
if (process.platform === 'win32') {
nodeFileTraceCompliantCode = nodeFileTraceCompliantCode.replaceAll(
'\\\\',
'/'
)
}
fs.mkdirSync(path.dirname(dstPath), { recursive: true })
fs.writeFileSync(dstPath, result.code)
fs.writeFileSync(dstPath, nodeFileTraceCompliantCode)

return dstPath
})
Expand Down