Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorial): Adds more TS hints in the toturial #6115

Merged
merged 5 commits into from
Aug 9, 2022

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented Aug 3, 2022

People following the tutorial seem to be getting caught out quite a lot by the TS errors.

This adds some extra tips to help deal with the situation.

@jtoar feel free to edit the copy as you see fit!

@dac09 dac09 requested a review from jtoar August 3, 2022 13:43
@nx-cloud
Copy link

nx-cloud bot commented Aug 3, 2022

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 538d052.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Aug 3, 2022

Deploy Preview for redwoodjs-docs ready!

Name Link
🔨 Latest commit 538d052
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62f277e473c4270009743d8a
😎 Deploy Preview https://deploy-preview-6115--redwoodjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dac09 dac09 added the release:docs This PR only updates docs label Aug 3, 2022
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dac09 made a few edits and have a few questions about making more changes to the RBAC section, but otherwise looks good

Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more edits, and approved

@jtoar jtoar enabled auto-merge (squash) August 9, 2022 15:06
@jtoar jtoar merged commit eecfaa4 into redwoodjs:main Aug 9, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Aug 9, 2022
dac09 added a commit to dac09/redwood that referenced this pull request Aug 9, 2022
…ac09/redwood into fix/user-scenarios-not-being-generated

* 'fix/user-scenarios-not-being-generated' of github.com:dac09/redwood:
  Amend import order in auth templates according to ESLint rules introduced in v2.0 (redwoodjs#6059)
  docs(tutorial): Adds more TS hints in the toturial (redwoodjs#6115)
  Revert auth provider refactor (redwoodjs#6135)
dac09 added a commit to dac09/redwood that referenced this pull request Aug 10, 2022
…-types-on-setup-auth

* 'main' of github.com:redwoodjs/redwood: (33 commits)
  fix(generators): Dont set tests=false in sdl generators by default (redwoodjs#6195)
  Harmonize optional chaining across all `hasRole` flavors & reduce duplication, avoiding errors on empty currentUser (redwoodjs#6159)
  Amend import order in auth templates according to ESLint rules introduced in v2.0 (redwoodjs#6059)
  docs(tutorial): Adds more TS hints in the toturial (redwoodjs#6115)
  Revert auth provider refactor (redwoodjs#6135)
  fix(deps): update docusaurus monorepo to v2.0.1 (redwoodjs#6176)
  fix(deps): update typescript-eslint monorepo to v5.33.0 (redwoodjs#6192)
  fix(deps): update dependency yargs-parser to v21.1.1 (redwoodjs#6191)
  fix(deps): update dependency fastify to v4.4.0 (redwoodjs#6190)
  fix(deps): update dependency @testing-library/user-event to v14.4.2 (redwoodjs#6189)
  chore(deps): update dependency @types/vscode to v1.70.0 (redwoodjs#6188)
  chore(deps): update dependency @types/prettier to v2.7.0 (redwoodjs#6187)
  fix(deps): update dependency systeminformation to v5.12.4 (redwoodjs#6186)
  chore(deps): update dependency @clerk/types to v2.21.0 (redwoodjs#6179)
  chore(deps): update dependency lerna to v5.4.0 (redwoodjs#6180)
  fix(deps): update prisma monorepo to v4.1.1 (redwoodjs#6181)
  chore(deps): update dependency @clerk/clerk-js to v3.17.0 (redwoodjs#6178)
  fix(deps): update storybook monorepo to v6.5.10 (redwoodjs#6177)
  fix(deps): update dependency @actions/core to v1.9.1 (redwoodjs#6175)
  chore(deps): update dependency magic-sdk to v9 (redwoodjs#6138)
  ...
@jtoar jtoar modified the milestones: next-release, v3.0.0 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants