-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scaffold.css.template #5582
Conversation
Fix a visual issue with the `.rw-table-wrapper-responsive` scrollbar, that made it look like an ellipse.
✅ Deploy Preview for redwoodjs-docs canceled.
|
@fakkio since this PR changes the template, it looks like you have to update a snapshot in one of the cli tests to get tests passing. That should be as easy as: cd packages/cli
yarn test -u
# commit changes but let me know if that doesn't end up working. |
@jtoar i failed 44 test on 48, this is the error:
Results:
I also tried to clone a fresh new project but i get the same error. I checked my |
@fakkio no worries, I think I forgot to tell you a step actually so my bad! You have to build the framework first. Try running yarn build # the step I forgot to mention
cd packages/cli
yarn test -u
# commit changes |
update snapshots after changing the template
@jtoar ok it worked, I've committed the new snapshots. Do I need to do anything else? |
Huh... that's not a style I added, I didn't even know you could do that. Might have been from a previous PR for someone tweaking the styles? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fakkio nothing else necessary to do, this looks good!
* Update scaffold.css.template Fix a visual issue with the `.rw-table-wrapper-responsive` scrollbar, that made it look like an ellipse. * test(cli): update snapshots update snapshots after changing the template Co-authored-by: Dominic Saadi <[email protected]>
* Update scaffold.css.template Fix a visual issue with the `.rw-table-wrapper-responsive` scrollbar, that made it look like an ellipse. * test(cli): update snapshots update snapshots after changing the template Co-authored-by: Dominic Saadi <[email protected]>
Fix a visual issue with the
.rw-table-wrapper-responsive
scrollbar, that made it look like an ellipse.