Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scaffold.css.template #5582

Merged
merged 5 commits into from
May 22, 2022
Merged

Update scaffold.css.template #5582

merged 5 commits into from
May 22, 2022

Conversation

fakkio
Copy link
Contributor

@fakkio fakkio commented May 18, 2022

Fix a visual issue with the .rw-table-wrapper-responsive scrollbar, that made it look like an ellipse.

Fix a visual issue with the `.rw-table-wrapper-responsive` scrollbar, that made it look like an ellipse.
@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 05b5746
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62899173c4ae670008b831f4

@jtoar jtoar self-assigned this May 19, 2022
@jtoar jtoar added topic/generators-&-scaffolds bug/needs-info More information is needed for reproduction release:fix This PR is a fix labels May 19, 2022
@jtoar
Copy link
Contributor

jtoar commented May 19, 2022

Hey @fakkio this is what this fixes right?

image

@cannikin did you get these styles from a source that had the 50% there originally for some reason?

@jtoar jtoar added bug/confirmed We have confirmed this is a bug action/add-to-cycle and removed bug/needs-info More information is needed for reproduction action/add-to-cycle labels May 19, 2022
@jtoar
Copy link
Contributor

jtoar commented May 19, 2022

@fakkio since this PR changes the template, it looks like you have to update a snapshot in one of the cli tests to get tests passing. That should be as easy as:

cd packages/cli
yarn test -u
# commit changes

but let me know if that doesn't end up working.

@fakkio
Copy link
Contributor Author

fakkio commented May 19, 2022

@fakkio since this PR changes the template, it looks like you have to update a snapshot in one of the cli tests to get tests passing. That should be as easy as:

cd packages/cli
yarn test -u
# commit changes

but let me know if that doesn't end up working.

@jtoar i failed 44 test on 48, this is the error:

Cannot find module '@redwoodjs/internal' from 'src/commands/__tests__/dev.test.js'

Results:

Test Suites: 44 failed, 4 passed, 48 total
Tests:       17 passed, 17 total
Snapshots:   0 total
Time:        7.579 s

I also tried to clone a fresh new project but i get the same error. I checked my node_modules and @redwood/internal is there.
I'm sorry to waste your time but i don't know what to do.

@jtoar
Copy link
Contributor

jtoar commented May 20, 2022

@fakkio no worries, I think I forgot to tell you a step actually so my bad! You have to build the framework first. Try running yarn build in the root of the framework before running yarn test -u in packages/cli and let me know if that works:

yarn build # the step I forgot to mention
cd packages/cli
yarn test -u
# commit changes

update snapshots after changing the template
@fakkio
Copy link
Contributor Author

fakkio commented May 20, 2022

@jtoar ok it worked, I've committed the new snapshots. Do I need to do anything else?

@cannikin
Copy link
Member

Huh... that's not a style I added, I didn't even know you could do that. Might have been from a previous PR for someone tweaking the styles?

Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fakkio nothing else necessary to do, this looks good!

@jtoar jtoar merged commit 9bea0a3 into redwoodjs:main May 22, 2022
jtoar added a commit that referenced this pull request May 22, 2022
* Update scaffold.css.template

Fix a visual issue with the `.rw-table-wrapper-responsive` scrollbar, that made it look like an ellipse.

* test(cli): update snapshots

update snapshots after changing the template

Co-authored-by: Dominic Saadi <[email protected]>
jtoar added a commit that referenced this pull request May 22, 2022
* Update scaffold.css.template

Fix a visual issue with the `.rw-table-wrapper-responsive` scrollbar, that made it look like an ellipse.

* test(cli): update snapshots

update snapshots after changing the template

Co-authored-by: Dominic Saadi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed We have confirmed this is a bug release:fix This PR is a fix topic/generators-&-scaffolds
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

3 participants