Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code block with typing error #5531

Merged
merged 2 commits into from
May 13, 2022
Merged

Remove code block with typing error #5531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2db7e48
Remove code block with typing error
Avataw May 13, 2022
b06f905
Merge branch 'main' into aw-docs-fix-form-type-error
Tobbe May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 5 additions & 42 deletions docs/docs/tutorial/chapter3/forms.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,7 +1236,9 @@ And notice that if you fill in something in a field that's marked as an error, t

### Validating Input Format

We should make sure the email field actually contains an email:
We should make sure the email field actually contains an email, by providing a `pattern`.
This is definitely not the end-all-be-all for email address validation, but for now let us pretend it's bulletproof.
Let's also change the message on the email validation to be a little more friendly:

<Tabs groupId="js-ts">
<TabItem value="js" label="JavaScript">
Expand All @@ -1249,6 +1251,7 @@ We should make sure the email field actually contains an email:
// highlight-start
pattern: {
value: /^[^@]+@[^.]+\..+$/,
message: 'Please enter a valid email address',
},
// highlight-end
}}
Expand All @@ -1267,49 +1270,9 @@ We should make sure the email field actually contains an email:
// highlight-start
pattern: {
value: /^[^@]+@[^.]+\..+$/,
},
// highlight-end
}}
errorClassName="error"
/>
```

</TabItem>
</Tabs>

That is definitely not the end-all-be-all for email address validation, but pretend it's bulletproof. Let's also change the message on the email validation to be a little more friendly:

<Tabs groupId="js-ts">
<TabItem value="js" label="JavaScript">

```jsx title="web/src/pages/ContactPage/ContactPage.js"
<TextField
name="email"
validation={{
required: true,
pattern: {
value: /^[^@]+@[^.]+\..+$/,
// highlight-next-line
message: 'Please enter a valid email address',
},
}}
errorClassName="error"
/>
```

</TabItem>
<TabItem value="ts" label="TypeScript">

```tsx title="web/src/pages/ContactPage/ContactPage.tsx"
<TextField
name="email"
validation={{
required: true,
pattern: {
value: /^[^@]+@[^.]+\..+$/,
// highlight-next-line
message: 'Please enter a valid email address',
},
// highlight-end
}}
errorClassName="error"
/>
Expand Down