-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Add Chakra UI integration #5031
Conversation
Installation does not belong to devDependencies Co-authored-by: Philzen <[email protected]>
✅ Deploy Preview for redwoodjs-docs canceled.
|
Good catch 👍 thanks for updating! |
Hi All! I think this one needs to be coordinated with the (herculean) effort happening in #4950 Looping in @Tobbe @nickpdemarco — could you two help plot a way forward here? Thanks, everyone! Stoked to see Chakra getting a lot of attention. |
Aha! I thought something was up here... https://github.com/redwoodjs/redwood/pull/3715/files#r834573794 AFAIK this is totally fine to go in and won't disrupt #4950. It'll be a trivial merge and then I can treat Mantine the same way; installing to regular dependencies. @Tobbe might see something I don't, so I'll defer to him. |
Ah, I just took a look at the code myself. This was actually an intentional choice, but I'm not sure it matters. @jtoar we decided to install Tailwindcss in devDependencies. We followed that pattern with Chakra, but this is the second time there's been a PR with a suggestion to move to dependencies. It doesn't really matter because our build-step is in a development context (does it)? I just want to be consistent and feel like we should have a rationale either way. |
99‰ of the time it won't matter if chakra/tw is a dep or devdep in a redwood app. The one time it does matter is if someone were to create an app/a library that uses RW that in turn was going to be installed as a dependency of some other app. In that case chakra and tw might not get installed even though it might be needed. So I'd say go ahead and switch to installing them all as a proper dependency. |
When I made the I just had a look at Chakra UI's docs and they recommend installing it as a @thedavidprice but I don't think we should remove the I haven't used Chakra a ton yet and am not a Tailwind expert either so I could be misinformed! But right now I do feel like they're separate libraries and deserve separate setup commands. Footnotes |
This is really helpful and, I suggest, should establish our rationale going forward:
😂 Sound like a plan? |
This is the way! |
@jtoar thanks again! @Tobbe @nickpdemarco FYI I'm merging this one now. @m3t Thank you! |
@thedavidprice Think you might have been a bit fast on the trigger here 🔫 🤠 Fix over here: #5085 |
Indeed. Grateful for friends like you watching my back!! |
I think @TimKolberger added a wrong argument for the installation of Chakra UI related packages in #3715
Whereas in the Chakra UI docs the packages live in
dependencies
devDependencies