[Tutorial] Chapter 2: Wrap rendered <article> in React fragments
#5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Philzen
force-pushed
the
5008-avoid-jsx-element-warning
branch
from
db954e7 to
947d3c8
Compare
This avoids warning `'ArticlesCell' cannot be used as a JSX component. Its return type 'Element[]' is not a valid JSX element.`. Closes redwoodjs#5008
Philzen
force-pushed
the
5008-avoid-jsx-element-warning
branch
from
d5d5baa to
b117719
Compare
|
Thanks! Are there any further instances of these same code snippets further on, or are these the only three? |
@cannikin at least as far as i could see – i searched through the tutorial until chapter 5 where the wrapper is different (and valid) already b/c of the tailwind redesign introduced during the "intermission" chapter. |
|
Great, thanks! |
Philzen
added a commit
to Philzen/redwood
that referenced
this pull request
Apr 5, 2022
Avoid invalid JSX element array, similar to redwoodjs#5020
jtoar
added a commit
that referenced
this pull request
May 4, 2022
…tutorial chapter 6 (#5058) * Remove unnecessary highlight (line is generated by default) * Keep React fragment as wrapping container Avoid invalid JSX element array, similar to #5020 * Fix highlighting b/c that lines actually changed as well * Add back highlight Going to add this back for now since it's used in the example Co-authored-by: Dominic Saadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids warning
'ArticlesCell' cannot be used as a JSX component. Its return type 'Element[]' is not a valid JSX element..Closes #5008