Update docs node version requirement to reflect current redwood reqs #5009
Conversation
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
BTW this is my first commit to an open source project, sorry if I borked something! |
dkmooers
changed the title
dkmooers
changed the title
|
Am I supposed to add a |
|
Welcome to Redwood! Glad to have you as a contributor. We will take care of the label. Do see my comment about bumping the version engine. Node.js does things in a unique way. |
thedavidprice
added
the
release:chore
| @@ -30,7 +30,7 @@ If you have an existing site created with a prior version, you'll need to upgrad | |||
|
|
|||
| During installation, RedwoodJS checks if your system meets version requirements for Node and Yarn: | |||
|
|
|||
| - node: ">=14.17 <=16.x" | |||
| - node: ">=14.19.0 <17.0.0" | |||
There was a problem hiding this comment.
Node versions are a peculiarity. In general, odd numbered versions are short-lived, development releases that are never long-term supported. Therefore, we do not support them. It's worth looking up the Node.js release schedule if you're never seen it before.
But we did bump the minimum to 14.19 for security and stability. Also, we don't include the patch semver because it may increase and that's desired to include.
So min should be 14.19 and max should stay as is.
…rsion at 14.19
|
OK great, updated min version to 14.19 and left max as is. |
|
Thank you! Merging now |
|
Yeah for sure, thanks! |
Wasn't sure whether to keep
<= 16.xformat from current docs, or switch to< 17.0.0from current redwood CLI error message, but opted for the latter