Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Clerk v3 upgrade #4968

Merged
merged 7 commits into from
Apr 15, 2022
Merged

Conversation

igneel64
Copy link
Contributor

Clerk upgrade to v3

  1. Upgrade Clerk auth libraries
  2. Introduce getToken options parameter for JWT templates on FE
  3. Add correct logout typings :)

Introduce getToken options parameter for JWT templates on FE
@netlify
Copy link

netlify bot commented Mar 30, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 27d6ca6
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/6259c694966b1b000839f04c

@igneel64 igneel64 marked this pull request as draft March 30, 2022 09:34
@Tobbe Tobbe self-assigned this Mar 30, 2022
@thedavidprice
Copy link
Contributor

🤘I'd love to get this into the RC patch.

@igneel64

  • is there anything existing projects will need to do or update? Assuming "no"
  • could you update from main locally and handle the yarn.lock conflict? Please run yarn check as well and follow any instructions to resolve issues if applicable.

Thanks!

@thedavidprice thedavidprice self-assigned this Mar 30, 2022
@Tobbe
Copy link
Member

Tobbe commented Mar 30, 2022

@igneel64 Thanks for getting the ball rolling on this! ⚽

Personally I'd prefer to wait with this until after V1. But that said, please do continue working on the PR. We can even merge it if we want. Just not cherry-pick it for inclusion in v1

@thedavidprice thedavidprice removed their assignment Mar 31, 2022
@thedavidprice
Copy link
Contributor

@Tobbe roger that ✅ I'll follow your lead here. Thanks!

@igneel64 igneel64 marked this pull request as ready for review April 1, 2022 08:58
@igneel64
Copy link
Contributor Author

igneel64 commented Apr 1, 2022

@thedavidprice @Tobbe
The required merge has been done, since there will be no change needed from a user point of view.
Let me know for anything needed.

It would be nice to see this moving forward 🤗

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Apr 1, 2022
@Tobbe
Copy link
Member

Tobbe commented Apr 1, 2022

I'll take this for a spin in a local project I have that uses Clerk. If that works (I'm sure it will) I'll merge this. Don't have time for that right now though, unfortunately

@igneel64
Copy link
Contributor Author

@Tobbe If you need any help or we have any news you can let me know 😄

@Tobbe
Copy link
Member

Tobbe commented Apr 14, 2022

@Tobbe If you need any help or we have any news you can let me know 😄

LOL. Thanks for the gentle nudge ❤️

I'll get to this one tomorrow. Pinky-swear.

@Tobbe Tobbe merged commit d511442 into redwoodjs:main Apr 15, 2022
@jtoar jtoar added this to the next-release milestone Apr 15, 2022
@Tobbe
Copy link
Member

Tobbe commented Apr 15, 2022

@igneel64 Thanks for the PR. Finally got around to testing it in a clerk app I have 🙂

@thedavidprice
Copy link
Contributor

I just cut the branch for 1.1 and released an RC. I've added the next-release-patch to remind me to cherry-pick this into the release branch for 1.1.0 release next Tuesday.

Thanks, all!

thedavidprice pushed a commit that referenced this pull request Apr 16, 2022
@nivivive
Copy link

@Tobbe do you have any examples of where we can update the code to take advantage of getToken(options) and pass the JWT template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users) topic/auth
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

5 participants