-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): Clerk v3 upgrade #4968
Conversation
Introduce getToken options parameter for JWT templates on FE
✅ Deploy Preview for redwoodjs-docs canceled.
|
🤘I'd love to get this into the RC patch.
Thanks! |
@igneel64 Thanks for getting the ball rolling on this! ⚽ Personally I'd prefer to wait with this until after V1. But that said, please do continue working on the PR. We can even merge it if we want. Just not cherry-pick it for inclusion in v1 |
@Tobbe roger that ✅ I'll follow your lead here. Thanks! |
@thedavidprice @Tobbe It would be nice to see this moving forward 🤗 |
I'll take this for a spin in a local project I have that uses Clerk. If that works (I'm sure it will) I'll merge this. Don't have time for that right now though, unfortunately |
@Tobbe If you need any help or we have any news you can let me know 😄 |
LOL. Thanks for the gentle nudge ❤️ I'll get to this one tomorrow. Pinky-swear. |
@igneel64 Thanks for the PR. Finally got around to testing it in a clerk app I have 🙂 |
I just cut the branch for 1.1 and released an RC. I've added the Thanks, all! |
Co-authored-by: Tobbe Lundberg <[email protected]>
@Tobbe do you have any examples of where we can update the code to take advantage of getToken(options) and pass the JWT template? |
Clerk upgrade to v3