Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Validations: Returns error message as an array in faked extensions #4792

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Service Validations: Returns error message as an array in faked extensions #4792

merged 4 commits into from
Mar 17, 2022

Conversation

cannikin
Copy link
Member

The new Service Validation update #4756 almost works, just a couple of tweaks:

  • the error message needs to be in the form of an array instead of a string
  • the field name is now included in the error message so no need to prefix on output
  • Update the title of the <FormError> box

Before this PR:

image

After this PR:

image

@netlify
Copy link

netlify bot commented Mar 17, 2022 •
edited
Loading

✔️ Deploy Preview for redwoodjs-docs canceled.

🔨 Explore the source changes: 4aa5406

🔍 Inspect the deploy log: https://app.netlify.com/sites/redwoodjs-docs/deploys/62339fcddb30520009eca801

@cannikin
Copy link
Member Author

I can update an important part of the tutorial once this gets in there so LET'S DO IT

@dthyresson dthyresson self-requested a review March 17, 2022 18:16
dthyresson
dthyresson approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I didn't see that in my form testing (or e2e but that must have been just regex).

@cannikin cannikin merged commit eb8503d into main Mar 17, 2022
@cannikin cannikin deleted the rc-extension-array branch March 17, 2022 21:58
@jtoar jtoar added this to the next-release milestone Mar 17, 2022
@thedavidprice thedavidprice modified the milestones: next-release, v0.50.0 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthyresson dthyresson dthyresson approved these changes

Assignees

@cannikin cannikin

Labels
release:fix This PR is a fix topic/forms
Projects
No open projects
Release
Status: Archived
Milestone
v0.50.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cannikin @dthyresson @thedavidprice @jtoar