Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg codemod for dev fatal error page #4790

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented Mar 17, 2022

What does this PR do?

Moves dev fatal error page from v0.46 to v0.49->v0.50.x, so its obvious that it should be used once we release the next version.

Nothing has been changed inside the codemod - although I've noticed that this codemod doesn't follow any of the standard patterns in the other ones 🤷

@netlify
Copy link

netlify bot commented Mar 17, 2022

✔️ Deploy Preview for redwoodjs-docs canceled.

🔨 Explore the source changes: a3fcc2a

🔍 Inspect the deploy log: https://app.netlify.com/sites/redwoodjs-docs/deploys/6233854cd36e29000a6f0fd7

@dac09 dac09 requested a review from dthyresson March 17, 2022 17:19
@dac09 dac09 added the release:chore This PR is a chore (means nothing for users) label Mar 17, 2022
@dthyresson
Copy link
Contributor

although I've noticed that this codemod doesn't follow any of the standard patterns in the other ones

I patterned it off packages/codemods/src/codemods/v0.38.x/updateSeedScript/updateSeedScript.ts

Or at least tried to.

@dac09
Copy link
Contributor Author

dac09 commented Mar 17, 2022

I patterned it off packages/codemods/src/codemods/v0.38.x/updateSeedScript/updateSeedScript.ts

Yeah no biggie! Just noticed that it doesn't use the utility function in packages/codemods/src/lib/fetchFileFromTemplate.ts. No real need to change now though!

@dthyresson
Copy link
Contributor

I patterned it off packages/codemods/src/codemods/v0.38.x/updateSeedScript/updateSeedScript.ts

Yeah no biggie! Just noticed that it doesn't use the utility function in packages/codemods/src/lib/fetchFileFromTemplate.ts. No real need to change now though!

Oh, I didn't know about that fetchFileFromTemplate ... I knew the seeds just replaced the file and did the same.

Good to know.

Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to fix the directory v47 instead of v0.47 now?

@dac09
Copy link
Contributor Author

dac09 commented Mar 17, 2022

Yeah problem with codemods I suppose is that our patterns evolve very quickly, hard to keep track!

@dac09
Copy link
Contributor Author

dac09 commented Mar 17, 2022

Did you want to fix the directory v47 instead of v0.47 now?

yeah done, made in v0.50.x though - that's what the PR does if you check the diff

@dthyresson dthyresson self-requested a review March 17, 2022 17:32
@dac09 dac09 closed this Mar 17, 2022
@dac09 dac09 reopened this Mar 17, 2022
@dac09 dac09 enabled auto-merge (squash) March 17, 2022 19:00
@dac09 dac09 merged commit e80c46f into redwoodjs:main Mar 17, 2022
@jtoar jtoar added this to the next-release milestone Mar 17, 2022
@dac09 dac09 deleted the fix/update-dev-fatal-error-codemod branch March 19, 2022 04:12
@thedavidprice thedavidprice modified the milestones: next-release, v0.50.0 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

4 participants