-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorg codemod for dev fatal error page #4790
Reorg codemod for dev fatal error page #4790
Conversation
✔️ Deploy Preview for redwoodjs-docs canceled. 🔨 Explore the source changes: a3fcc2a 🔍 Inspect the deploy log: https://app.netlify.com/sites/redwoodjs-docs/deploys/6233854cd36e29000a6f0fd7 |
I patterned it off redwood/packages/codemods/src/codemods/v0.38.x/updateSeedScript/updateSeedScript.ts Line 43 in 28ad2c8
Or at least tried to. |
Yeah no biggie! Just noticed that it doesn't use the utility function in |
Oh, I didn't know about that Good to know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to fix the directory v47
instead of v0.47
now?
Yeah problem with codemods I suppose is that our patterns evolve very quickly, hard to keep track! |
yeah done, made in v0.50.x though - that's what the PR does if you check the diff |
What does this PR do?
Moves dev fatal error page from v0.46 to v0.49->v0.50.x, so its obvious that it should be used once we release the next version.
Nothing has been changed inside the codemod - although I've noticed that this codemod doesn't follow any of the standard patterns in the other ones 🤷