Add @storybook/addon-essentials by default #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoncrypta
added
topic/storybook
release:feature
virtuoushub
reviewed
Mar 19, 2022
✅ Deploy Preview for redwoodjs-docs canceled.
|
Tobbe
force-pushed
the
sg-storybook-addon-essentials
branch
from
81fb7f6 to
93aabb8
Compare
Tobbe
force-pushed
the
sg-storybook-addon-essentials
branch
from
93aabb8 to
485ae68
Compare
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Mar 31, 2022
…nto fix/subdirectory-routing * 'fix/subdirectory-routing' of github.com:dac09/redwood: Clarify the cell aliasing section of tutorial (redwoodjs#4964) s/posts/articles (redwoodjs#4971) fix(deps): update dependency cross-undici-fetch to v0.1.28 (redwoodjs#4966) Add Storybook template for i18n (redwoodjs#4764) Add @storybook/addon-essentials by default (redwoodjs#4765)
virtuoushub
added a commit
to redwoodjs/example-storybook
that referenced
this pull request
Apr 25, 2022
redwoodjs/redwood#4765 added `@storybook/addon-essentials` by default, and was included in 1.1.0 adding it twice causes an issue in webpack. not sure if the work in redwoodjs/redwood#4900 will help prevent this type of thing in the future. need to follow up closes #43
virtuoushub
added a commit
to redwoodjs/example-storybook
that referenced
this pull request
Apr 25, 2022
redwoodjs/redwood#4765 added `@storybook/addon-essentials` by default, and was included in 1.1.0 adding it twice causes an issue in webpack. not sure if the work in redwoodjs/redwood#4900 will help prevent this type of thing in the future. need to follow up closes #43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think Storybook Essentials should be by default on every project.
This give all these tools :
Actions
Backgrounds
Controls
Docs
Viewport
Toolbars (Need for #4764)