-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow Redirect to use navigate options.replace #4704
Conversation
Thanks @odjhey. I like this! Could you please try to add some tests as well? Let me know if you need any pointers. We'll also need doc updates for this. |
@Tobbe , sure thing! i'll see what I can do, will reach out when I get stuck! Thank you! |
I wanted docs for this section: https://redwoodjs.com/docs/router#redirect Code is over here: https://github.com/redwoodjs/redwoodjs.com/blob/main/docs/router.md?plain=1#L486-L499 |
The test you added was really good. Just made a suggestion for another comment explaining what's going on |
Co-authored-by: Tobbe Lundberg <[email protected]>
Cool .")b Thanks! I have included your proposed changes in this PR. |
This was a great first PR @odjhey. I'm already looking forward to the next one 😄 |
@Tobbe thanks to your awesome work :) will for sure send your way any future updates we think is godo. cheers! ".)v |
…ecks-smoke-test * 'main' of github.com:redwoodjs/redwood: allow Redirect to use navigate options.replace (redwoodjs#4704) Update dependency eslint to v8.11.0 (redwoodjs#4727) Update dependency systeminformation to v5.11.8 (redwoodjs#4726) Update dependency @clerk/clerk-sdk-node to v2.9.9 (redwoodjs#4720) Fix failing codemod test for RedwoodDevFatalErrorPage (redwoodjs#4723) Update dependency @clerk/clerk-js to v2.17.4 (redwoodjs#4719) Pretty print query in DevFatalErrorPage for better DX and readability (redwoodjs#4696)
Allow history overwrite(replace?) when using the
<Redirect>
component from@redwoodjs/router