Netlify client getToken fix when GoTrue client refreshes JWT #4539
Conversation
dthyresson
changed the title
I also thought that was the problem, but it wasn't. It's that we now always (unconditionally) call I believe the netlify-identity-widget is doing the wrong thing here when it's throwing the null exception. I wrote a PR for it. netlify/netlify-identity-widget#516 |
| try { | ||
| const user = await client.currentUser() | ||
| return user?.jwt() || null | ||
| } catch { |
There was a problem hiding this comment.
We're swallowing error messages here. Is there any way we can be more helpful to the developer? I don't like just printing things to the console the the end-developer can't do anything about. But I also don't like swallowing errors that the developer might want to know about, and might want to track in something like Sentry in production.
There was a problem hiding this comment.
Open to alternatives — I didn’t check what happens if an error is raised but wasn’t that the issue? An error here broke cell data fetching?
There was a problem hiding this comment.
I left my comment open ended because I couldn't think of a good alternative. Was hoping you could come up with something 🙃
Let's merge this so our users can have working auth again. Then revisit when the netlify people have answered on my PR.
| const user = await client.currentUser() | ||
| return user?.token?.access_token || null | ||
| } catch { | ||
| return null |
…test * 'main' of github.com:redwoodjs/redwood: (23 commits) Netlify client getToken fix when GoTrue client refreshes JWT (redwoodjs#4539) Update dependency @supabase/supabase-js to v1.30.4 (redwoodjs#4536) Envelop: Don't use useImmediateIntrospection as it causes auth bug (redwoodjs#4538) Update dependency react-hook-form to v7.27.1 (redwoodjs#4521) try increasing timeout for flaky test (redwoodjs#4526) Update dependency stacktracey to v2.1.8 (redwoodjs#4519) Update dependency msw to v0.38.1 (redwoodjs#4525) Update dependency eslint-config-prettier to v8.4.0 (redwoodjs#4522) Provide a Revised Runtime Error Page (redwoodjs#4167) update yarn.lock v0.46.0 Update dependency esbuild to v0.14.23 (redwoodjs#4518) Fix Storybook build args (redwoodjs#4455) Update dependency react-helmet-async to v1.2.3 (redwoodjs#4502) Bump url-parse in /__fixtures__/example-todo-main-with-errors (redwoodjs#4511) Bump url-parse from 1.5.1 to 1.5.7 in /__fixtures__/example-todo-main (redwoodjs#4512) Update dependency fastify to v3.27.2 (redwoodjs#4516) Uncomment role checks (redwoodjs#4476) Update dependency zx to v5.1.0 (redwoodjs#4505) Update dependency firebase to v9.6.7 (redwoodjs#4514) ...
This PR fixes an issue in the Netlify authentication client where refreshing and getting a token can cause an error such as:
Because of a null default value set as part of the isAuthentication fix to set default values: https://github.com/redwoodjs/redwood/pull/4320/files
This PR catches any error from the Netlify client sdk and handles it.
Note that it isn't client that's null and raising the error as checking from it still causes the error.
Edit: Also added some check for the GoTrue client, since it is the same underneath.