Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): Disable sourcemaps in prod #3953

Merged
merged 3 commits into from
Dec 20, 2021

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented Dec 20, 2021

What does this do?

Disable sourcemaps in prod for the web side unless explicitly enabled in toml

How the toml setting works and why?

#redwood.toml
[web]
  #...
  sourceMap = true 

If you set sourceMap to true, it'll will build with source maps even in production. This might be useful in certain scenarios, where you're getting an error in production but not in dev.

Fixes #2416

unless explicitly enabled in toml
@dac09 dac09 added the topic/config Babel, Webpack, ESLint, Prettier, etc. label Dec 20, 2021
@dac09 dac09 requested a review from jtoar December 20, 2021 16:22
@dac09 dac09 assigned dac09 and jtoar Dec 20, 2021
@jtoar jtoar enabled auto-merge (squash) December 20, 2021 18:03
@jtoar jtoar merged commit 42f942b into redwoodjs:main Dec 20, 2021
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Dec 20, 2021
@dac09 dac09 deleted the fix/disable-srcmaps-prod branch December 20, 2021 19:21
@thedavidprice
Copy link
Contributor

@dac09 @jtoar How should we handle docs given the streamlined release process?

  • I'm no longer auditing and keeping track
  • Maybe as simple as creating an associated issue that's immediately added to Release board In progress?

@jtoar
Copy link
Contributor

jtoar commented Dec 21, 2021

I'll give a more complete answer sometime this week, but for now using the next-release/update-docs label still seems like a good way of going about it.

One way we could do it: using that label, the fact that project boards can have issues/PRs from multiple repos, and the "Linked Pull Requests" field, we can track the status of the issue/PR's corresponding docs:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/config Babel, Webpack, ESLint, Prettier, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcemaps are not disabled in production
3 participants