Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the new Set component to the Router docs #2097

Merged
merged 6 commits into from
Mar 25, 2021
Merged

Add the new Set component to the Router docs #2097

merged 6 commits into from
Mar 25, 2021

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Mar 25, 2021

Documents the new Set component introduced in #1898.

@jtoar jtoar self-assigned this Mar 25, 2021
@github-actions
Copy link

github-actions bot commented Mar 25, 2021 •
edited
Loading

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/create-redwood-app-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-api-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-api-server-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-auth-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-cli-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-core-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-dev-server-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-eslint-config-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-eslint-plugin-redwood-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-forms-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-internal-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-prerender-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-router-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-structure-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-testing-0.27.1-3369028.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2097/redwoodjs-web-0.27.1-3369028.tgz

Install this PR by running yarn rw upgrade --pr 2097:0.27.1-3369028

@jtoar jtoar marked this pull request as ready for review March 25, 2021 16:44
@cypress
Copy link

cypress bot commented Mar 25, 2021 •
edited
Loading


Test summary

11 • 0 • 1 • 0 • Flakiness 0

Run details
Project RedwoodJS Framework
Status Passed
Commit ad4b7c4 ℹ️
Started Mar 25, 2021 5:06 PM
Ended Mar 25, 2021 5:09 PM
Duration 02:32 💡
OS Linux Ubuntu - 20.04
Browser Chrome 89

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Tobbe
Tobbe approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@Tobbe Tobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Change if you want. Ignore if you want.

@jtoar jtoar force-pushed the ds-update-router-docs branch from 8d159fe to 3369028 Compare March 25, 2021 17:02
@thedavidprice thedavidprice merged commit b33e0dd into main Mar 25, 2021
@thedavidprice thedavidprice deleted the ds-update-router-docs branch March 25, 2021 18:32
@thedavidprice thedavidprice added this to the next release milestone Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedavidprice thedavidprice thedavidprice approved these changes

@Tobbe Tobbe Tobbe approved these changes

Assignees

@jtoar jtoar

Labels
topic/docs topic/router-&-navigation
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jtoar @thedavidprice @Tobbe @redwoodjsbot