Fix check for nodejs and yarn versions #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsen1
pushed a commit
to mohsen1/redwood
that referenced
this pull request
Apr 12, 2020
…nd-yarn-versions Fix check for nodejs and yarn versions
jtoar
added a commit
that referenced
this pull request
Mar 18, 2022
jtoar
added a commit
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thedavidprice The task to check for node and yarn versions was not working properly. I decided to use the programmatic API instead.
Listr swallows a bunch of the output so I also decided to split out the functionality into individual functions which made it easier to test during development.
I also removed the bit of code that set the title in the html template and used the functionality that's included in html webpack plugin.
Closes #114