[CLI] Refactor & simplify schema helpers #11896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philzen
force-pushed
the
refactor/simplify-schema-helpers
branch
from
5140fe7 to
2278409
Compare
Philzen
force-pushed
the
refactor/simplify-schema-helpers
branch
from
2278409 to
d65d975
Compare
Philzen
changed the title
Tobbe
reviewed
Jan 15, 2025
|
I'm a big fan of early returns. Thanks for cleaning up the code @Philzen 🙏 |
My pleasure – it's sort of my professional OCD anyway, causing me to act whenever i spot such code smells. |
Tobbe
added a commit
that referenced
this pull request
Jan 16, 2025
Co-authored-by: Tobbe Lundberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on another PR i skimmed through this file and recognized some code block that could be written simpler and with less indentation by applying the early return pattern, thus reducing the cognitive complexity required to mentally process the code.
The iterative process of simplifying the code then uncovered a potential
undefinedreturn value (→ ec50ab8) in thegetSchema()method, which i marked with a TODO comment for further consideration.