Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

few Flightcontrol template & doc updates #11383

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

flybayer
Copy link
Contributor

@flybayer flybayer commented Aug 28, 2024

few Flightcontrol template & doc updates

closes #10754

@Josh-Walker-GM
Copy link
Collaborator

Thanks for this! I assume this will fix #10754 at the same time?

You can run yarn format or yarn format:check from the root of the repo to have prettier update any formatting issues it sees.

@flybayer
Copy link
Contributor Author

@Josh-Walker-GM yes it will. Unfortunately I'm unable to get the right yarn version working, corepack is giving the wrong version of v1, and so install doesn't work 😓

@Josh-Walker-GM
Copy link
Collaborator

@flybayer Okay no worries. If this is good to go I'll review it tonight and get it merged in?

@flybayer
Copy link
Contributor Author

good to go!

@Josh-Walker-GM Josh-Walker-GM self-requested a review August 29, 2024 11:27
@Josh-Walker-GM Josh-Walker-GM self-assigned this Aug 29, 2024
@Josh-Walker-GM Josh-Walker-GM added the release:docs This PR only updates docs label Aug 29, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the next-release milestone Aug 29, 2024
@Josh-Walker-GM Josh-Walker-GM added release:fix This PR is a fix and removed release:docs This PR only updates docs labels Aug 29, 2024
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested deploying an example app and it worked well for me.

@Josh-Walker-GM Josh-Walker-GM merged commit 09d090f into redwoodjs:main Aug 29, 2024
50 checks passed
dac09 added a commit to dac09/redwood that referenced this pull request Aug 30, 2024
…edwood into feat/prisma-extension-crud-extra

* 'feat/prisma-extension-crud-extra' of github.com:dac09/redwood:
  feat(codegen): support sdl generation for model with compound id (redwoodjs#8556)
  chore(ci): Follow up to workflow permissions (redwoodjs#11397)
  chore(deps): Bump 'loader-utils' within docs (redwoodjs#11396)
  chore(ci): Pin action dependencies by digest (redwoodjs#11395)
  chore(ci): More workflow permission changes (redwoodjs#11394)
  chore(ci): Add permissions to some workflows/jobs (redwoodjs#11393)
  Add OSSF scorecard action to our CI (redwoodjs#11392)
  chore(rsc): Rename rsf -> rsa (redwoodjs#11391)
  few Flightcontrol template & doc updates (redwoodjs#11383)
  chore(jobs tests): Fix a couple of TS issues (redwoodjs#11389)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: next-release, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug?]: Flight control deployment not working
2 participants