-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Running rw sls deploy on windows does not package src/lib #5852
Comments
I am currently investigating. Don't hold your breath, I'm slow. |
After some poking around this morning it looks like an issue with windows pathing not being supported by nodeFileTrace. I will verify later today, then see if its easier to just make a work around on our end, or add a feature to nodeFileTrace. might also be how our builder handles windows pathing as the only things not being traced are imports with \\ |
* issue#5852 added windows fix for nodeFileTrace * Update packages/internal/src/build/api.ts unregexed. Co-authored-by: Tobbe Lundberg <[email protected]> * Update packages/internal/src/build/web.ts unregexed Co-authored-by: Tobbe Lundberg <[email protected]> * issue# 5852 now only the import files are changed. * issue #5852 only import files changed. * Adds test for src-alias plugin - unlikely to work on Windows Co-authored-by: Tobbe Lundberg <[email protected]> Co-authored-by: Daniel Choudhury <[email protected]>
Fixed by #6325 |
* issue#5852 added windows fix for nodeFileTrace * Update packages/internal/src/build/api.ts unregexed. Co-authored-by: Tobbe Lundberg <[email protected]> * Update packages/internal/src/build/web.ts unregexed Co-authored-by: Tobbe Lundberg <[email protected]> * issue# 5852 now only the import files are changed. * issue #5852 only import files changed. * Adds test for src-alias plugin - unlikely to work on Windows Co-authored-by: Tobbe Lundberg <[email protected]> Co-authored-by: Daniel Choudhury <[email protected]>
* issue#5852 added windows fix for nodeFileTrace * Update packages/internal/src/build/api.ts unregexed. Co-authored-by: Tobbe Lundberg <[email protected]> * Update packages/internal/src/build/web.ts unregexed Co-authored-by: Tobbe Lundberg <[email protected]> * issue# 5852 now only the import files are changed. * issue #5852 only import files changed. * Adds test for src-alias plugin - unlikely to work on Windows Co-authored-by: Tobbe Lundberg <[email protected]> Co-authored-by: Daniel Choudhury <[email protected]>
What's not working?
When trying to deploy the API side using the serverless integration, builds on Windows deploy correctly, but have runtime errors.
How do we reproduce the bug?
yarn rw setup deploy serverless
yarn rw deploy serverless --side api
Analysis
The other files references by the function aren't being pulled into the zipball.
You can see this is the case by doing:
yarn rw deploy serverless --side api --pack-only
./api/dist/zipball/[functionName].zip
- and you will notice "src/lib" is missing - this is where logger, db, etc. usually sit.It likely is an issue with how we call
nodeFileTrace
or how we handle the result of running that.What's your environment? (If it applies)
Are you interested in working on this?
The text was updated successfully, but these errors were encountered: