fix: flattened optional type not optional #4317
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ade18b1:
|
|
when will you merge it? |
the maintainers aren’t as familiar with code gen so mightn’t be too quick. if you’d like, by clicking on “details” next to the code sandbox merge workflow, there are instructions to use this PR in your package.json |
|
hi there, any chance someone can take a look at this? |
|
Looks reasonable, thanks! |
|
Should be live in https://github.com/reduxjs/redux-toolkit/releases/tag/%40rtk-query%2Fcodegen-openapi%402.0.0-alpha.0 ! Please try it out and let us know if it works. |
when flattening an argument, if the type is optional, it should be a union with undefined.
the PR implements this by adding a union node for the type of the arg. if the type is required, then the union node function is given just the original type and returns it. if the type is not required, then the union node function is given the original type and the undefined keyword, creating an optional type.
see issue #4304 for inspiration