Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Reducer<S, AnyAction> from createReducer #104

Merged
merged 1 commit into from
Jan 27, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/createReducer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ export interface CaseReducersMapObject<S = any, A extends Action = AnyAction> {
export function createReducer<S = any, A extends Action = AnyAction>(
initialState: S,
actionsMap: CaseReducersMapObject<S, A>
): Reducer<S, A> {
): Reducer<S> {
return function(state = initialState, action): S {
// @ts-ignore createNextState() produces an Immutable<Draft<S>> rather
// than an Immutable<S>, and TypeScript cannot find out how to reconcile
// these two types.
return createNextState(state, (draft: Draft<S>) => {
const caseReducer = actionsMap[action.type]
return caseReducer ? caseReducer(draft, action) : undefined
return caseReducer ? caseReducer(draft, action as A) : undefined
})
}
}
7 changes: 2 additions & 5 deletions type-tests/files/createReducer.typetest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,10 @@ import { AnyAction, createReducer, Reducer } from 'redux-starter-kit'
decrement: decrementHandler
})

const numberReducer: Reducer<number, CounterAction> = reducer
const numberReducer: Reducer<number> = reducer

// typings:expect-error
const stringReducer: Reducer<string, CounterAction> = reducer

// typings:expect-error
const anyActionReducer: Reducer<number, AnyAction> = reducer
const stringReducer: Reducer<string> = reducer
}

/**
Expand Down