Refactor fields and descriptors #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haveyaseen
added
type: Enhancement
haveyaseen
force-pushed
the
feature/refactor_fields
branch
from
9010f15 to
e4cbc2b
Compare
haveyaseen
force-pushed
the
feature/refactor_fields
branch
from
6f7b4ce to
0dd9931
Compare
haveyaseen
added a commit
that referenced
this pull request
Jun 18, 2018
haveyaseen
added
layer: Fields
type: Chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves imperative field installation logic out of field classes, the classes now only contain more or less declarative information on whether or not
virtualFieldsanddescriptorsshould be installed for forwards and backwards fields. The same goes for the creation of through models.Cleans up
fields.jsanddescriptors.jsdrastically making it easier to reason about field installation and relationship lookup. Still not perfect but a necessary step to aid in the understanding of these crucial elements.Increases
descriptors.jscoverage to 100%. 🎉