Added Uruguay ID (IC) validator #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOlival
requested changes
Oct 10, 2020
Comment on lines
29
to
33
| $this->invalidIds = [ | ||
| '46057422', | ||
| '90224632', | ||
| '52631437', | ||
| ]; |
There was a problem hiding this comment.
Can we get at least two more invalid ids?
| $baseDigit = $baseNumber[$i]; | ||
| $ciDigit = $id[$i]; | ||
|
|
||
| $a += (intval($baseDigit) * intval($ciDigit)) % 10; |
There was a problem hiding this comment.
Use a cast to int rather than intval for better performance
|
Fixes done |
AlexOlival
added a commit
that referenced
this pull request
Feb 6, 2021
* Create Europe folder * Add Europe folder to tests * Implement USA validator * Change name to United States instead * Implement Canada * Follow PSR * Small fix * Sort config validators alphabetically * Add link to source information for the algorithms of Belgium. (#75) * Feature/make classes abstract (#88) * Make Gender.php class abstract * Make Countries.php class abstract * Fix ID validation Belgium. (#91) * Added Chile ID (RUT) validator (#81) * Implement Chile ID validator and tests * Added Argentina ID (CUIL/CUIT) validator (#80) * Implement Argentina ID validator and tests Co-authored-by: Rodolpho Lima <[email protected]> * Added Uruguay ID (IC) validator (#95) * implement Uruguay ID validator * improvements uruguay id validator Co-authored-by: Rodolpho Lima <[email protected]> * feat: Mexican ID Validator (#78) Implement Mexico * Added Peru ID (CUI) validator (#98) * Added Peru ID validation Co-authored-by: Rodolpho Lima <[email protected]> * Add german TIN validator (#97) * Add german TIN validator * Adjust documentation for germany * Added Ecuador ID (IC) validator (#104) * implement ecuador id * fixes ecuador validator Co-authored-by: Rodolpho Lima <[email protected]> * Add countries constants * add missing countries and update docs * Remove Laravel locale detection * Remove locale detection test * Add native DateTime support and deprecate the old getDateOfBirth method (#109) * Add getDateOfBirthNative() method * Fix Belgium integration * Update InvalidLengthException.php (#110) * Improve Contributing Guide (#111) * Update CONTRIBUTING.md * Remove unnecessary trim * Remove unnecessary trim * Small fix * [v1.3.0] Disable Luxembourg and improve documentation (#112) * Remove Luxembourg * Improve docs * Fix Luxembourg tests * Update image * Update Build yml file * Add support for PHP 8 (#114) * Add support for PHP 8 Co-authored-by: João Cruz <[email protected]> Co-authored-by: Yves Bos <[email protected]> Co-authored-by: bofalke <[email protected]> Co-authored-by: Rodolpho Lima <[email protected]> Co-authored-by: Rodolpho Lima <[email protected]> Co-authored-by: tiagomichaelsousa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #94
It includes the validator itself and unit tests.