Merge pull request #38 from redpencilio/bugfix/prevent-concurrent-tas…

…k-runs When cronjob is scheduled at a faster rate than the job duration itself, a new task run was run
redpencilio · Jul 27, 2023 · 8262622 · 8262622
2 parents 0ee12d6 + 843608f
commit 8262622
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1,3 @@
 node_modules
-.vscode
+.vscode
+.idea
diff --git a/app.ts b/app.ts
@@ -77,16 +77,20 @@ const consumerJob = new CronJob(CRON_PATTERN, async () => {
       console.log("Another task is still running");
       return;
     }
+
     taskIsRunning = true;
     const stream = namedNode(LDES_STREAM);
     const initialState = await fetchState(stream);
     const endpoint = LDES_ENDPOINT_VIEW;
+
     console.log("RUN CONSUMER");
+
     const ldesOptions = {
       dereferenceMembers: LDES_DEREFERENCE_MEMBERS,
       disablePolling: RUNONCE,
       pollingInterval: LDES_POLLING_INTERVAL
     };
+
     if (LDES_REQUESTS_PER_MINUTE) {
       ldesOptions.requestsPerMinute = LDES_REQUESTS_PER_MINUTE;
     }
@@ -131,7 +135,6 @@ const consumerJob = new CronJob(CRON_PATTERN, async () => {
     }
   } catch (e) {
     console.error(e);
-  } finally {
     taskIsRunning = false;
   }
 });