Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add IsParseErr helper(issue 559) #564

Merged
merged 6 commits into from
Jun 16, 2024
Merged

feat: Add IsParseErr helper(issue 559) #564

merged 6 commits into from
Jun 16, 2024

Conversation

LWF15
Copy link
Contributor

@LWF15 LWF15 commented Jun 13, 2024

add the global variable call ErrParse and set it to the struct of RedisMessage as function IsParseErr and add some judgment condition in some toXX() type method in PR555

message.go Outdated Show resolved Hide resolved
message.go Outdated Show resolved Hide resolved
message.go Outdated Show resolved Hide resolved
@LWF15
Copy link
Contributor Author

LWF15 commented Jun 13, 2024

by the way, sorry about the title, I remember the wrong issue I working with Q A Q

@rueian
Copy link
Collaborator

rueian commented Jun 14, 2024

by the way, sorry about the title, I remember the wrong issue I working with Q A Q

No worry. Please also write a test for the IsParseErr.

@LWF15
Copy link
Contributor Author

LWF15 commented Jun 15, 2024

by the way, sorry about the title, I remember the wrong issue I working with Q A Q

No worry. Please also write a test for the IsParseErr.

Ok, I will wrote it

@rueian rueian merged commit 463b6c3 into redis:main Jun 16, 2024
21 checks passed
@rueian
Copy link
Collaborator

rueian commented Jun 16, 2024

Merged. Thank you for your contributions @LWF15!

This was referenced Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants