Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reconstruct client-side caching in rueidislock after extending key validities #546

Merged
merged 3 commits into from
May 23, 2024
Merged

perf: reconstruct client-side caching in rueidislock after extending key validities #546

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cff97a
perf: reconstruct client-side caching in rueidislock after extending …
rueian May 21, 2024
079e5ab
perf: reconstruct client-side caching in rueidislock after extending …
rueian May 22, 2024
b9dbe74
perf: acquiring locks using lua scripts in rueidislock
rueian May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions rueidislock/lock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ func NewLocker(option LockerOption) (Locker, error) {
}
option.ClientOption.OnInvalidations = impl.onInvalidations
}
option.ClientOption.PipelineMultiplex = -1 // this ensures the CSC goes to the same connection.

var err error
if option.ClientBuilder != nil {
Expand Down Expand Up @@ -160,15 +161,14 @@ func keyname(prefix, name string, i int32) string {

func (m *locker) acquire(ctx context.Context, key, val string, deadline time.Time) (err error) {
ctx, cancel := context.WithTimeout(ctx, m.timeout)
var set rueidis.Completed
var resp rueidis.RedisResult
if m.setpx {
set = m.client.B().Set().Key(key).Value(val).Nx().PxMilliseconds(m.validity.Milliseconds()).Build()
resp = acqms.Exec(ctx, m.client, []string{key}, []string{val, strconv.FormatInt(m.validity.Milliseconds(), 10)})
} else {
set = m.client.B().Set().Key(key).Value(val).Nx().PxatMillisecondsTimestamp(deadline.UnixMilli()).Build()
resp = acqat.Exec(ctx, m.client, []string{key}, []string{val, strconv.FormatInt(deadline.UnixMilli(), 10)})
}
resp := m.client.DoMulti(ctx, set, m.client.B().Get().Key(key).Build())
cancel()
if err = resp[0].Error(); rueidis.IsRedisNil(err) {
if err = resp.Error(); rueidis.IsRedisNil(err) {
return ErrNotLocked
}
return err
Expand Down Expand Up @@ -390,8 +390,10 @@ func (m *locker) Close() {
}

var (
delkey = rueidis.NewLuaScript(`if redis.call("GET",KEYS[1]) == ARGV[1] then return redis.call("DEL",KEYS[1]) else return 0 end`)
extend = rueidis.NewLuaScript(`if redis.call("GET",KEYS[1]) == ARGV[1] then return redis.call("PEXPIREAT",KEYS[1],ARGV[2]) else return 0 end`)
delkey = rueidis.NewLuaScript(`if redis.call("GET",KEYS[1]) == ARGV[1] then return redis.call("DEL",KEYS[1]) end;return 0`)
extend = rueidis.NewLuaScript(`if redis.call("GET",KEYS[1]) == ARGV[1] then local r = redis.call("PEXPIREAT",KEYS[1],ARGV[2]);redis.call("GET",KEYS[1]);return r end;return 0`)
acqms = rueidis.NewLuaScript(`local r = redis.call("SET",KEYS[1],ARGV[1],"NX","PX",ARGV[2]);redis.call("GET",KEYS[1]);return r`)
acqat = rueidis.NewLuaScript(`local r = redis.call("SET",KEYS[1],ARGV[1],"NX","PXAT",ARGV[2]);redis.call("GET",KEYS[1]);return r`)
)

// ErrNotLocked is returned from the Locker.TryWithContext when it fails
Expand Down
Loading