feat: Add a helper generic function DecodeSliceOfJSON #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
==========================================
+ Coverage 95.57% 95.60% +0.02%
==========================================
Files 80 80
Lines 33178 33192 +14
==========================================
+ Hits 31710 31732 +22
+ Misses 1267 1260 -7
+ Partials 201 200 -1 ☔ View full report in Codecov by Sentry. |
rueian
reviewed
Apr 2, 2024
The error-handling parts are covered by tests. Could you also add some tests for them?
|
|
Sorry @sgasho, I didn't notice that your original version can actually work with both |
rueian
approved these changes
Apr 2, 2024
ash2k
reviewed
Apr 9, 2024
| var t T | ||
| if err = v.DecodeJSON(&t); err != nil { | ||
| if IsRedisNil(err) { | ||
| continue |
There was a problem hiding this comment.
Ah, I see there is a test for this behavior, so probably it is a desired behavior. Sorry for the noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a helper function DecodeSliceOfJSON to struct scan a redis result.
code provided in #521 (comment) did not work so I changed a little.
Related Issue
close #521