Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let clusterclient respect the option.PipelineMultiplex #418

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

rueian
Copy link
Collaborator

@rueian rueian commented Dec 10, 2023

Resolves #417

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3851dec) 97.02% compared to head (5ca6ad6) 97.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   97.02%   97.00%   -0.02%     
==========================================
  Files          76       76              
  Lines       31591    31588       -3     
==========================================
- Hits        30650    30643       -7     
- Misses        793      795       +2     
- Partials      148      150       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salarali
Copy link

@rueian
Copy link
Collaborator Author

rueian commented Dec 10, 2023

Would also need to update the documentation: https://github.com/redis/rueidis/blob/3851dec72cb1f34c5eb39a85df8ad952b28f9508/rueidis.go#L128C54-L128C54

Sure! Good catch.

Copy link

@salarali salarali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes.

@rueian rueian merged commit 9dea63a into main Dec 10, 2023
@rueian rueian added the feature label Dec 10, 2023
@rueian rueian deleted the multiple-tcp-for-cluster-node branch December 15, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PipelineMultiplex for cluster
3 participants