-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add String() to rueidis.RedisResult for easy debugging #353
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
- Coverage 97.61% 97.56% -0.05%
==========================================
Files 76 76
Lines 30467 30524 +57
==========================================
+ Hits 29739 29780 +41
- Misses 613 623 +10
- Partials 115 121 +6
☔ View full report in Codecov by Sentry. |
Hi @Exca-DK, Thank you for implementing this. However, I am hesitant about adding the People will most likely expect the I think we had better just keep the Stringer interface which is widely accepted as a debugging helper. |
You are right, I made it into an internal type, it shouldn't be known to people at all. What do you think? |
Hi @Exca-DK, |
Add tests
Thanks @Exca-DK! |
RedisResult
for easy debugging
RedisResult
for easy debugging
closes #292