Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RE tests #3114

Closed
wants to merge 9 commits into from
Closed

Add RE tests #3114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6951be8
Add RE tests
dvora-h Jan 16, 2024
bf621df
fix syntax
dvora-h Jan 16, 2024
0341816
fix syntax
dvora-h Jan 16, 2024
374c09a
try to access secrets
dvora-h Jan 17, 2024
923f9a8
seperate files
dvora-h Jan 17, 2024
6c388eb
removing, just to check
chayim Jan 18, 2024
c684347
ent
chayim Jan 18, 2024
f187c0c
looking at the login
chayim Jan 18, 2024
eded681
sec
chayim Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
395 changes: 224 additions & 171 deletions .github/workflows/integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,171 +1,224 @@
name: CI

on:
push:
paths-ignore:
- 'docs/**'
- '**/*.rst'
- '**/*.md'
branches:
- master
- '[0-9].[0-9]'
pull_request:
branches:
- master
- '[0-9].[0-9]'
schedule:
- cron: '0 1 * * *' # nightly build

concurrency:
group: ${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

permissions:
contents: read # to fetch code (actions/checkout)

jobs:

dependency-audit:
name: Dependency audit
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pypa/[email protected]
with:
inputs: requirements.txt dev_requirements.txt
ignore-vulns: |
GHSA-w596-4wvx-j9j6 # subversion related git pull, dependency for pytest. There is no impact here.

lint:
name: Code linters
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.9
cache: 'pip'
- name: run code linters
run: |
pip install -r dev_requirements.txt
invoke linters

run-tests:
runs-on: ubuntu-latest
timeout-minutes: 60
strategy:
max-parallel: 15
fail-fast: false
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', 'pypy-3.8', 'pypy-3.9']
test-type: ['standalone', 'cluster']
connection-type: ['hiredis', 'plain']
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
name: Python ${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}} tests
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
- name: run tests
run: |
pip install -U setuptools wheel
pip install -r requirements.txt
pip install -r dev_requirements.txt
if [ "${{matrix.connection-type}}" == "hiredis" ]; then
pip install hiredis
fi
invoke devenv
sleep 10 # time to settle
invoke ${{matrix.test-type}}-tests

- uses: actions/upload-artifact@v4
if: success() || failure()
with:
name: pytest-results-${{matrix.test-type}}-${{matrix.connection-type}}-${{matrix.python-version}}
path: '${{matrix.test-type}}*results.xml'

- name: Upload codecov coverage
uses: codecov/codecov-action@v3
with:
fail_ci_if_error: false

- name: View Test Results
uses: dorny/test-reporter@v1
if: success() || failure()
continue-on-error: true
with:
name: Test Results ${{matrix.python-version}} ${{matrix.test-type}}-${{matrix.connection-type}}
path: '*.xml'
reporter: java-junit
list-suites: all
list-tests: all
max-annotations: 10
fail-on-error: 'false'

resp3_tests:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.11']
test-type: ['standalone', 'cluster']
connection-type: ['hiredis', 'plain']
protocol: ['3']
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
name: RESP3 [${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}}]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
- name: run tests
run: |
pip install -U setuptools wheel
pip install -r requirements.txt
pip install -r dev_requirements.txt
if [ "${{matrix.connection-type}}" == "hiredis" ]; then
pip install hiredis
fi
invoke devenv
sleep 5 # time to settle
invoke ${{matrix.test-type}}-tests
invoke ${{matrix.test-type}}-tests --uvloop

build_and_test_package:
name: Validate building and installing the package
runs-on: ubuntu-latest
needs: [run-tests]
strategy:
fail-fast: false
matrix:
extension: ['tar.gz', 'whl']
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.9
- name: Run installed unit tests
run: |
bash .github/workflows/install_and_test.sh ${{ matrix.extension }}

install_package_from_commit:
name: Install package from commit hash
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', 'pypy-3.8', 'pypy-3.9']
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
- name: install from pip
run: |
pip install --quiet git+${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}.git@${GITHUB_SHA}
# name: CI

# on:
# push:
# paths-ignore:
# - 'docs/**'
# - '**/*.rst'
# - '**/*.md'
# branches:
# - master
# - '[0-9].[0-9]'
# pull_request:
# branches:
# - master
# - '[0-9].[0-9]'
# schedule:
# - cron: '0 1 * * *' # nightly build

# concurrency:
# group: ${{ github.event.pull_request.number || github.ref }}
# cancel-in-progress: true

# permissions:
# contents: read # to fetch code (actions/checkout)

# jobs:

# dependency-audit:
# name: Dependency audit
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - uses: pypa/[email protected]
# with:
# inputs: requirements.txt dev_requirements.txt
# ignore-vulns: |
# GHSA-w596-4wvx-j9j6 # subversion related git pull, dependency for pytest. There is no impact here.

# lint:
# name: Code linters
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - uses: actions/setup-python@v5
# with:
# python-version: 3.9
# cache: 'pip'
# - name: run code linters
# run: |
# pip install -r dev_requirements.txt
# invoke linters

# run-tests:
# runs-on: ubuntu-latest
# timeout-minutes: 60
# strategy:
# max-parallel: 15
# fail-fast: false
# matrix:
# python-version: ['3.8', '3.9', '3.10', '3.11', 'pypy-3.8', 'pypy-3.9']
# test-type: ['standalone', 'cluster']
# connection-type: ['hiredis', 'plain']
# env:
# ACTIONS_ALLOW_UNSECURE_COMMANDS: true
# name: Python ${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}} tests
# steps:
# - uses: actions/checkout@v4
# - uses: actions/setup-python@v5
# with:
# python-version: ${{ matrix.python-version }}
# cache: 'pip'
# - name: run tests
# run: |
# pip install -U setuptools wheel
# pip install -r requirements.txt
# pip install -r dev_requirements.txt
# if [ "${{matrix.connection-type}}" == "hiredis" ]; then
# pip install hiredis
# fi
# invoke devenv
# sleep 10 # time to settle
# invoke ${{matrix.test-type}}-tests

# - uses: actions/upload-artifact@v4
# if: success() || failure()
# with:
# name: pytest-results-${{matrix.test-type}}-${{matrix.connection-type}}-${{matrix.python-version}}
# path: '${{matrix.test-type}}*results.xml'

# - name: Upload codecov coverage
# uses: codecov/codecov-action@v3
# with:
# fail_ci_if_error: false

# - name: View Test Results
# uses: dorny/test-reporter@v1
# if: success() || failure()
# continue-on-error: true
# with:
# name: Test Results ${{matrix.python-version}} ${{matrix.test-type}}-${{matrix.connection-type}}
# path: '*.xml'
# reporter: java-junit
# list-suites: all
# list-tests: all
# max-annotations: 10
# fail-on-error: 'false'

# resp3_tests:
# runs-on: ubuntu-latest
# strategy:
# fail-fast: false
# matrix:
# python-version: ['3.8', '3.11']
# test-type: ['standalone', 'cluster']
# connection-type: ['hiredis', 'plain']
# protocol: ['3']
# env:
# ACTIONS_ALLOW_UNSECURE_COMMANDS: true
# name: RESP3 [${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}}]
# steps:
# - uses: actions/checkout@v4
# - uses: actions/setup-python@v5
# with:
# python-version: ${{ matrix.python-version }}
# cache: 'pip'
# - name: run tests
# run: |
# pip install -U setuptools wheel
# pip install -r requirements.txt
# pip install -r dev_requirements.txt
# if [ "${{matrix.connection-type}}" == "hiredis" ]; then
# pip install hiredis
# fi
# invoke devenv
# sleep 5 # time to settle
# invoke ${{matrix.test-type}}-tests
# invoke ${{matrix.test-type}}-tests --uvloop

# # enterprise_tests:
# # runs-on: ubuntu-latest
# # strategy:
# # fail-fast: false
# # matrix:
# # python-version: ['3.10']
# # test-type: ['standalone']
# # connection-type: ['hiredis', 'plain']
# # re-build: ["7.2.4-92"]
# # env:
# # ACTIONS_ALLOW_UNSECURE_COMMANDS: true
# # name: RE [${{ matrix.re-build }} ${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}}]
# # steps:
# # - name: Checkout code
# # uses: actions/checkout@v4

# # - name: Clone Redis EE docker repository
# # uses: actions/checkout@v4
# # with:
# # repository: RedisLabs/redis-ee-docker
# # path: redis-ee

# # - name: Set up python ${{ matrix.python-version }}
# # uses: actions/setup-python@v5
# # with:
# # python-version: ${{ matrix.python-version }}
# # cache: 'pip'

# # - name: Build cluster
# # working-directory: redis-ee
# # env:
# # IMAGE: "redislabs/redis-internal:${{ matrix.re-build }}"
# # RE_USERNAME: [email protected]
# # RE_PASS: 12345
# # RE_CLUSTER_NAME: test
# # RE_USE_OSS_CLUSTER: false
# # RE_DB_PORT: 6379
# # DOCKER_ACCESS_TOKEN: ${{ secrets.DOCKER_ACCESS_TOKEN }}
# # DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
# # run: ./build.sh

# # - name: Run tests
# # run: |
# # pip install -U setuptools wheel
# # pip install -r requirements.txt
# # pip install -r dev_requirements.txt
# # if [ "${{matrix.connection-type}}" == "hiredis" ]; then
# # pip install hiredis
# # fi
# # invoke devenv
# # sleep 10 # time to settle
# # invoke ${{matrix.test-type}}-tests

# build_and_test_package:
# name: Validate building and installing the package
# runs-on: ubuntu-latest
# needs: [run-tests]
# strategy:
# fail-fast: false
# matrix:
# extension: ['tar.gz', 'whl']
# steps:
# - uses: actions/checkout@v4
# - uses: actions/setup-python@v5
# with:
# python-version: 3.9
# - name: Run installed unit tests
# run: |
# bash .github/workflows/install_and_test.sh ${{ matrix.extension }}

# install_package_from_commit:
# name: Install package from commit hash
# runs-on: ubuntu-latest
# strategy:
# fail-fast: false
# matrix:
# python-version: ['3.8', '3.9', '3.10', '3.11', 'pypy-3.8', 'pypy-3.9']
# steps:
# - uses: actions/checkout@v4
# - uses: actions/setup-python@v5
# with:
# python-version: ${{ matrix.python-version }}
# cache: 'pip'
# - name: install from pip
# run: |
# pip install --quiet git+${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}.git@${GITHUB_SHA}
Loading