-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redis 7.2.0 tests #2902
Fix redis 7.2.0 tests #2902
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2902 +/- ##
==========================================
+ Coverage 90.91% 91.27% +0.36%
==========================================
Files 126 126
Lines 32384 32368 -16
==========================================
+ Hits 29441 29544 +103
+ Misses 2943 2824 -119
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About removed tests, is possible just to ignore those tests? I.e. with tag? So that when we have environment with WAITAOF support, we can enable it.
@@ -267,6 +267,7 @@ class AbstractRedisCluster: | |||
"READONLY", | |||
"CLUSTER INFO", | |||
"CLUSTER MEET", | |||
"CLUSTER MYSHARDID", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this command implemented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
redis-py/redis/commands/cluster.py
Line 638 in 28cc65c
def cluster_myshardid(self, target_nodes=None): |
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.