Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redis 7.2.0 tests #2902

Merged
merged 6 commits into from
Aug 21, 2023
Merged

Fix redis 7.2.0 tests #2902

merged 6 commits into from
Aug 21, 2023

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 20, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.36% 🎉

Comparison is base (28cc65c) 90.91% compared to head (e35952d) 91.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2902      +/-   ##
==========================================
+ Coverage   90.91%   91.27%   +0.36%     
==========================================
  Files         126      126              
  Lines       32384    32368      -16     
==========================================
+ Hits        29441    29544     +103     
+ Misses       2943     2824     -119     
Files Changed Coverage Δ
redis/cluster.py 92.81% <ø> (+0.10%) ⬆️
tests/test_asyncio/test_commands.py 99.72% <100.00%> (+2.59%) ⬆️
tests/test_commands.py 98.56% <100.00%> (+1.66%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Aug 20, 2023
@dvora-h dvora-h requested a review from a team August 21, 2023 06:19
Copy link

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About removed tests, is possible just to ignore those tests? I.e. with tag? So that when we have environment with WAITAOF support, we can enable it.

@@ -267,6 +267,7 @@ class AbstractRedisCluster:
"READONLY",
"CLUSTER INFO",
"CLUSTER MEET",
"CLUSTER MYSHARDID",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this command implemented?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

def cluster_myshardid(self, target_nodes=None):

@dvora-h dvora-h merged commit 6968431 into redis:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants