Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for redis functions #2020

Merged
merged 21 commits into from
Apr 25, 2022
Merged

Add support for redis functions #2020

merged 21 commits into from
Apr 25, 2022

Conversation

leibale
Copy link
Contributor

@leibale leibale commented Mar 2, 2022

Fixes #1937, Fixes #1938, Fixes #1942, Fixes #1943, Fixes #1944, Fixes #1945, Fixes #1946, Fixes #1947, Fixes #1948, Fixes #1949, Fixes #1950, Fixes #1951, Fixes #1990

@leibale leibale marked this pull request as draft March 2, 2022 13:23
@lgtm-com
Copy link

lgtm-com bot commented Mar 2, 2022

This pull request introduces 3 alerts and fixes 2 when merging ec16a5b into 9180b91 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 7, 2022

This pull request introduces 3 alerts and fixes 2 when merging 0ba5234 into 9180b91 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 10, 2022

This pull request introduces 3 alerts and fixes 2 when merging 42b90d4 into bae54f1 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #2020 (902bbf5) into master (23b6513) will decrease coverage by 0.35%.
The diff coverage is 82.74%.

❗ Current head 902bbf5 differs from pull request most recent head 802c517. Consider uploading reports for the commit 802c517 to get more accurate results

@@            Coverage Diff             @@
##           master    #2020      +/-   ##
==========================================
- Coverage   95.46%   95.10%   -0.36%     
==========================================
  Files         396      409      +13     
  Lines        3682     3803     +121     
  Branches      442      458      +16     
==========================================
+ Hits         3515     3617     +102     
- Misses         87       96       +9     
- Partials       80       90      +10     
Impacted Files Coverage Δ
packages/client/lib/lua-script.ts 100.00% <ø> (ø)
packages/client/lib/multi-command.ts 81.81% <33.33%> (-11.04%) ⬇️
packages/client/lib/cluster/multi-command.ts 60.00% <35.71%> (-4.71%) ⬇️
packages/client/lib/client/multi-command.ts 82.00% <37.50%> (-3.42%) ⬇️
packages/client/lib/cluster/index.ts 72.46% <62.50%> (-5.67%) ⬇️
packages/client/lib/client/index.ts 87.06% <84.00%> (-0.32%) ⬇️
packages/client/lib/commander.ts 88.37% <86.20%> (-3.06%) ⬇️
packages/client/lib/commands/FUNCTION_STATS.ts 87.50% <87.50%> (ø)
...ckages/client/lib/commands/generic-transformers.ts 99.51% <90.00%> (-0.49%) ⬇️
index.ts 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b6513...802c517. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Mar 10, 2022

This pull request introduces 3 alerts and fixes 2 when merging 5c1525a into bae54f1 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 10, 2022

This pull request introduces 3 alerts and fixes 2 when merging 3304b5c into be51abe - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

leibale added a commit to leibale/node-redis that referenced this pull request Mar 30, 2022
leibale added a commit to leibale/node-redis that referenced this pull request Mar 30, 2022
leibale added a commit that referenced this pull request Mar 30, 2022
* run tests on redis 7 as well - copied from #2020

* copy some changes from #2020

* clean BITCOUNT
@lgtm-com
Copy link

lgtm-com bot commented Apr 3, 2022

This pull request introduces 3 alerts and fixes 2 when merging 85c7acd into 0f65690 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 11, 2022

This pull request introduces 3 alerts and fixes 2 when merging fec0501 into 329885b - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 13, 2022

This pull request introduces 3 alerts and fixes 2 when merging 4428971 into c473c5f - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 13, 2022

This pull request introduces 3 alerts and fixes 2 when merging 4c6970d into c473c5f - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 18, 2022

This pull request introduces 3 alerts and fixes 2 when merging fe00969 into 79ee8f2 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@leibale leibale marked this pull request as ready for review April 25, 2022 12:39
@lgtm-com
Copy link

lgtm-com bot commented Apr 25, 2022

This pull request introduces 3 alerts and fixes 2 when merging 74a6fb8 into 23b6513 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 25, 2022

This pull request introduces 3 alerts and fixes 2 when merging 802c517 into 23b6513 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@leibale leibale merged commit 11c6c24 into redis:master Apr 25, 2022
@leibale leibale deleted the functions branch April 25, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment