docs: improve docs on connect_timeout vs options.retry_strategy and some testing help #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what is wrong with the actions, I tried on my fork and the "Run ataylorme/[email protected]" works just fine there (I changed the "on pull request" to "push", but that's probably not the problem. Here it errors with "##[error]Resource not accessible by integration". |
gkorland
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It took me quite some time to figure out why the auto-reconnect stopped after 1 hour, even when trying all possible different retry_strategy options, which turned out to be undocumented connect_timeout parameter. The code comments mentions that this behaviour should be changed in v3.0, but apparently that has not been implemented yet, so my addition to the docs seems correct. Not sure if related to #1444.
I also added a bit more info to be able to run the tests, and fixed some whitespaces.
Checklist
npm testpass with this change (including linting)?