Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lettuce EntraID integration tests #3133

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Lettuce EntraID integration tests #3133

merged 6 commits into from
Jan 21, 2025

Conversation

ggivo
Copy link
Contributor

@ggivo ggivo commented Jan 17, 2025 •
edited
Loading

Prepare EntraId integration tests for inclusion in EntraId nightly tests

Changes introduced with this review:

  • Separated EntraID standalone & cluster tests (EntraIdIntegrationTests.java, EntraIdClusterIntegrationTests.java)
  • Added EntraID managed identity integration test - EntraIdManagedIdentityIntegrationTests.java
  • Read EntraID test env settings from endpoints.json
  • get rid of dotenv-java
  • EntraID related tests marked with entraid tag

To run entraId-related tests you use:
mvn integration-test -Pentraid-it

Prerequisites:

  • Redis server configured with enabled EntraID authentication
  • Provide required info in EntraIdTestContext.

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

ggivo added 6 commits January 16, 2025 15:13
@ggivo
EntraId integration test - integrate with cae infra
d233ce8 
 - Read test endpoint's configuration from endpoint's json
 - Invoke only EntraId related test:
  mvn  integration-test -Pentraid-it
@ggivo
Load EntraIdTest
fa91350 
 from environment variables directly

remove dotenv dependency
@ggivo
Replace whoami check with get/set to not depend on username
0f5e5c4
@ggivo
Remove deprecated dnsResolver
d9b6e5c
@ggivo
use mset to test default connection, and ping for individual node con…
8cec0f0 
…nections
@ggivo
Add EntraId managed identity integration test
06dad40
@ggivo ggivo requested a review from tishun January 20, 2025 12:16
tishun
tishun approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both me and Copilot do not see anything worth mentioning

@ggivo ggivo merged commit ee7c46c into redis:main Jan 21, 2025
5 checks passed
@ggivo ggivo deleted the lettuce-entraid-it branch January 21, 2025 13:11
big-cir added a commit to big-cir/lettuce that referenced this pull request Jan 24, 2025
@big-cir
Revert "Lettuce EntraID integration tests (redis#3133)"
6cc9b54 
This reverts commit ee7c46c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tishun tishun tishun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggivo @tishun