Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test with issue hidden due to optional client name #3357

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

sazzad16
Copy link
Contributor

@sazzad16 sazzad16 commented Apr 6, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (3e8a584) 67.05% compared to head (0f3d852) 67.04%.

❗ Current head 0f3d852 differs from pull request most recent head e984c6b. Consider uploading reports for the commit e984c6b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3357      +/-   ##
============================================
- Coverage     67.05%   67.04%   -0.02%     
+ Complexity     4656     4655       -1     
============================================
  Files           263      263              
  Lines         15072    15072              
  Branches        947      947              
============================================
- Hits          10107    10105       -2     
- Misses         4557     4558       +1     
- Partials        408      409       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -231,20 +231,23 @@ public void cleanUp() {
}
};

// TODO: do it without the help of pool config; from Connection constructor? (configurable) force ping?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: do it without the help of pool config; from Connection constructor? (configurable) force ping?

I don't think we need to do much about it.

If the user's JedisPoolConfig does not configure the correct password, it is normal to return NOAUTH in subsequent requests.

@sazzad16 sazzad16 merged commit 3b46620 into redis:master Apr 7, 2023
@sazzad16 sazzad16 deleted the fix-test-1 branch April 7, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants