Improve safety of MultiNodePipelineBase under multi-thread #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzad16
reviewed
Mar 22, 2023
sazzad16
approved these changes
Mar 22, 2023
sazzad16
changed the title
banker
pushed a commit
to banker/jedis
that referenced
this pull request
Mar 28, 2023
* Make sure MultiNodePipelineBase is safe under multi-thread * Edit log message --------- Co-authored-by: Stiller <[email protected]> Co-authored-by: M Sazzadul Hoque <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiNodePipelineBase is not safe in multi-thread when it used the same nodeKey to call appendCommand()
it would cause connection leak，because the map: connections just can record one connection for one nodeKey and there is no lock to protect it;