Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update optimize_shards_placement.md #1103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JeffreyGroves
Copy link
Contributor

Adding omitted /v1 prepend to REST API URL

I'm not sure why the /v1 string would be listed in the syntax at the start but omitted throughout the rest of the document.

Adding omitted `/v1` prepend to REST API URL
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dwdougherty dwdougherty added the rs Redis Enterprise Software label Jan 29, 2025
@rrelledge
Copy link
Collaborator

@JeffreyGroves The absence of v1 originated from the REST API documentation packaged with Redis Software. I'm not sure if there's a specific reason for this, but all of the endpoints do this.

@rrelledge
Copy link
Collaborator

rrelledge commented Jan 29, 2025

@maayanagranat Is this something we should go ahead and change? As I said in my previous comment, this is something that originated from the REST API tarballs that we used to create the docs on the site, and it affects all example requests in the reference docs. All endpoints have the correct version in the initial syntax example shown though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rs Redis Enterprise Software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants