Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting issues #386

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fix formatting issues #386

merged 2 commits into from
Jan 29, 2025

Conversation

atakavci
Copy link
Collaborator

No description provided.

@atakavci atakavci self-assigned this Jan 27, 2025
@atakavci atakavci requested review from uglide and slorello89 January 27, 2025 12:49
uglide
uglide approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd document .runsettings in developer notes so people know where this magic comes from

@atakavci atakavci merged commit 8a17e47 into redis:master Jan 29, 2025
15 of 21 checks passed
@atakavci atakavci mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uglide uglide uglide approved these changes

@slorello89 slorello89 Awaiting requested review from slorello89

Assignees

@atakavci atakavci

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atakavci @uglide