Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply avoiding assembly level parallelism for enterprise redis and windows tests on CI #327

Merged
merged 1 commit into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
run: dotnet build --no-restore /p:ContinuousIntegrationBuild=true

- name: Test
run: dotnet test -f net8.0 --no-build --verbosity detailed
run: dotnet test -f net8.0 --no-build --verbosity detailed -p:BuildInParallel=false tests/Test.proj

dotnet_6_cluster:
name: .NET 6 on [redis-stack cluster]
Expand Down Expand Up @@ -175,4 +175,4 @@ jobs:
shell: cmd
run: |
START wsl ./redis-stack-server-${{env.redis_stack_version}}/bin/redis-stack-server &
dotnet test -f net481 --no-build --verbosity detailed
dotnet test -f net481 --no-build --verbosity detailed -p:BuildInParallel=false tests/Test.proj
9 changes: 3 additions & 6 deletions src/NRedisStack/Bloom/IBloomCommands.cs
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,9 @@ public interface IBloomCommands
/// <param name="items">One or more items to add.</param>
/// <param name="capacity">(Optional) Specifies the desired capacity for the filter to be created.</param>
/// <param name="error">(Optional) Specifies the error ratio of the newly created filter if it does not yet exist.</param>
/// <param name="expansion">(Optional) When capacity is reached, an additional sub-filter is
/// created in size of the last sub-filter multiplied by expansion.</param>
/// <param name="nocreate">(Optional) <see langword="true"/> to indicates that the
/// filter should not be created if it does not already exist.</param>
/// <param name="nonscaling">(Optional) <see langword="true"/> toprevent the filter
/// from creating additional sub-filters if initial capacity is reached.</param>
/// <param name="expansion">(Optional) When capacity is reached, an additional sub-filter is created in size of the last sub-filter multiplied by expansion.</param>
/// <param name="nocreate">(Optional) <see langword="true"/> to indicates that the filter should not be created if it does not already exist.</param>
/// <param name="nonscaling">(Optional) <see langword="true"/> toprevent the filter from creating additional sub-filters if initial capacity is reached.</param>
/// <returns>An array of booleans. Each element is either true or false depending on whether the
/// corresponding input element was newly added to the filter or may have previously existed.</returns>
/// <remarks><seealso href="https://redis.io/commands/bf.insert"/></remarks>
Expand Down
6 changes: 2 additions & 4 deletions src/NRedisStack/Bloom/IBloomCommandsAsync.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,8 @@ public interface IBloomCommandsAsync
/// <param name="error">(Optional) Specifies the error ratio of the newly created filter if it does not yet exist.</param>
/// <param name="expansion">(Optional) When capacity is reached, an additional sub-filter is
/// created in size of the last sub-filter multiplied by expansion.</param>
/// <param name="nocreate">(Optional) <see langword="true"/> to indicates that the
/// filter should not be created if it does not already exist.</param>
/// <param name="nonscaling">(Optional) <see langword="true"/> toprevent the filter
/// from creating additional sub-filters if initial capacity is reached.</param>
/// <param name="nocreate">(Optional) <see langword="true"/> to indicates that the filter should not be created if it does not already exist.</param>
/// <param name="nonscaling">(Optional) <see langword="true"/> toprevent the filter from creating additional sub-filters if initial capacity is reached.</param>
/// <returns>An array of booleans. Each element is either true or false depending on whether the
/// corresponding input element was newly added to the filter or may have previously existed.</returns>
/// <remarks><seealso href="https://redis.io/commands/bf.insert"/></remarks>
Expand Down
4 changes: 2 additions & 2 deletions src/NRedisStack/CuckooFilter/ICuckooCommands.cs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public interface ICuckooCommands
/// <param name="key">The name of the filter.</param>
/// <param name="items">One or more items to add.</param>
/// <param name="capacity">(Optional) Specifies the desired capacity for the filter to be created.</param>
/// <param name="nocreate">(Optional) <see langword="true"/> to indicates that the
/// <param name="nocreate">(Optional) <see langword="true"/> to indicates that the filter should not be created if it does not already exist.</param>
/// <returns>An array of booleans.</returns>
/// <remarks><seealso href="https://redis.io/commands/cf.insert"/></remarks>
bool[] Insert(RedisKey key, RedisValue[] items, int? capacity = null, bool nocreate = false);
Expand All @@ -76,7 +76,7 @@ public interface ICuckooCommands
/// <param name="key">The name of the filter.</param>
/// <param name="items">One or more items to add.</param>
/// <param name="capacity">(Optional) Specifies the desired capacity for the filter to be created.</param>
/// <param name="nocreate">(Optional) <see langword="true"/> to indicates that the
/// <param name="nocreate">(Optional) <see langword="true"/> to indicates that the filter should not be created if it does not already exist.</param>
/// <returns>An array of booleans.where <see langword="true"/> means the item has been added to the filter,
/// and <see langword="false"/> mean, the item already existed</returns>
/// <remarks><seealso href="https://redis.io/commands/cf.insertnx"/></remarks>
Expand Down
7 changes: 3 additions & 4 deletions src/NRedisStack/CuckooFilter/ICuckooCommandsAsync.cs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public interface ICuckooCommandsAsync
/// <param name="key">The name of the filter.</param>
/// <param name="items">One or more items to add.</param>
/// <param name="capacity">(Optional) Specifies the desired capacity for the filter to be created.</param>
/// <param name="nocreate">(Optional) <see langword="true"/> to indicates that the
/// <param name="nocreate">(Optional) <see langword="true"/> to indicates that the filter should not be created if it does not already exist.</param>
/// <returns>An array of booleans.</returns>
/// <remarks><seealso href="https://redis.io/commands/cf.insert"/></remarks>
Task<bool[]> InsertAsync(RedisKey key, RedisValue[] items, int? capacity = null, bool nocreate = false);
Expand All @@ -76,9 +76,8 @@ public interface ICuckooCommandsAsync
/// <param name="key">The name of the filter.</param>
/// <param name="items">One or more items to add.</param>
/// <param name="capacity">(Optional) Specifies the desired capacity for the filter to be created.</param>
/// <param name="nocreate">(Optional) <see langword="true"/> to indicates that the
/// <returns>An array of booleans.where <see langword="true"/> means the item has been added to the filter,
/// and <see langword="false"/> mean, the item already existed</returns>
/// <param name="nocreate">(Optional) <see langword="true"/> to indicates that the filter should not be created if it does not already exist.</param>
/// <returns>An array of booleans.where <see langword="true"/> means the item has been added to the filter, and <see langword="false"/> mean, the item already existed</returns>
/// <remarks><seealso href="https://redis.io/commands/cf.insertnx"/></remarks>
Task<bool[]> InsertNXAsync(RedisKey key, RedisValue[] items, int? capacity = null, bool nocreate = false);

Expand Down
4 changes: 2 additions & 2 deletions src/NRedisStack/Gears/GearsCommands.cs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public static Dictionary<string, RedisResult>[] TFunctionList(this IDatabase db,
/// <param name="functionName">The function name to run.</param>
/// <param name="keys">keys that will be touched by the function.</param>
/// <param name="args">Additional argument to pass to the function.</param>
/// <returns>The return value from the sync & async function on error in case of failure.</returns>
/// <returns>The return value from the sync &amp; async function on error in case of failure.</returns>
/// <remarks><seealso href="https://redis.io/commands/tfcall"/></remarks>
public static RedisResult TFCall_(this IDatabase db, string libraryName, string functionName, string[]? keys = null, string[]? args = null)
{
Expand All @@ -68,7 +68,7 @@ public static RedisResult TFCall_(this IDatabase db, string libraryName, string
/// <param name="functionName">The function name to run.</param>
/// <param name="keys">keys that will be touched by the function.</param>
/// <param name="args">Additional argument to pass to the function.</param>
/// <returns>The return value from the sync & async function on error in case of failure.</returns>
/// <returns>The return value from the sync &amp; async function on error in case of failure.</returns>
/// <remarks><seealso href="https://redis.io/commands/tfcallasync"/></remarks>
public static RedisResult TFCallAsync_(this IDatabase db, string libraryName, string functionName, string[]? keys = null, string[]? args = null)
{
Expand Down
4 changes: 2 additions & 2 deletions src/NRedisStack/Gears/GearsCommandsAsync.cs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public static async Task<Dictionary<string, RedisResult>[]> TFunctionListAsync(t
/// <param name="functionName">The function name to run.</param>
/// <param name="keys">keys that will be touched by the function.</param>
/// <param name="args">Additional argument to pass to the function.</param>
/// <returns>The return value from the sync & async function on error in case of failure.</returns>
/// <returns>The return value from the sync &amp; async function on error in case of failure.</returns>
/// <remarks><seealso href="https://redis.io/commands/tfcall"/></remarks>
public async static Task<RedisResult> TFCall_Async(this IDatabase db, string libraryName, string functionName, string[]? keys = null, string[]? args = null)
{
Expand All @@ -67,7 +67,7 @@ public async static Task<RedisResult> TFCall_Async(this IDatabase db, string lib
/// <param name="functionName">The function name to run.</param>
/// <param name="keys">keys that will be touched by the function.</param>
/// <param name="args">Additional argument to pass to the function.</param>
/// <returns>The return value from the sync & async function on error in case of failure.</returns>
/// <returns>The return value from the sync &amp; async function on error in case of failure.</returns>
/// <remarks><seealso href="https://redis.io/commands/tfcallasync"/></remarks>
public async static Task<RedisResult> TFCallAsync_Async(this IDatabase db, string libraryName, string functionName, string[]? keys = null, string[]? args = null)
{
Expand Down
4 changes: 2 additions & 2 deletions src/NRedisStack/Graph/IGraphCommands.cs
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,15 @@ public interface IGraphCommands
/// Set the value of a RedisGraph configuration parameter.
/// </summary>
/// <param name="configName">The config name.</param>
/// <returns>Dictionary of <string, object>.</returns>
/// <returns>Dictionary of &lt;string, object&gt;.</returns>
/// <remarks><seealso href="https://redis.io/commands/graph.config-get"/></remarks>
Dictionary<string, RedisResult> ConfigGet(string configName);

/// <summary>
/// Returns a list containing up to 10 of the slowest queries issued against the given graph Name.
/// </summary>
/// <param name="graphName">The graph name.</param>
/// <returns>Dictionary of <string, object>.</returns>
/// <returns>Dictionary of &lt;string, object&gt;.</returns>
/// <remarks><seealso href="https://redis.io/commands/graph.slowlog"/></remarks>
List<List<string>> Slowlog(string graphName);
}
Expand Down
4 changes: 2 additions & 2 deletions src/NRedisStack/Graph/IGraphCommandsAsync.cs
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,15 @@ public interface IGraphCommandsAsync
/// Set the value of a RedisGraph configuration parameter.
/// </summary>
/// <param name="configName">The config name.</param>
/// <returns>Dictionary of <string, object>.</returns>
/// <returns>Dictionary of &lt;string, object&gt;.</returns>
/// <remarks><seealso href="https://redis.io/commands/graph.config-get"/></remarks>
Task<Dictionary<string, RedisResult>> ConfigGetAsync(string configName);

/// <summary>
/// Returns a list containing up to 10 of the slowest queries issued against the given graph Name.
/// </summary>
/// <param name="graphName">The graph name.</param>
/// <returns>Dictionary of <string, object>.</returns>
/// <returns>Dictionary of &lt;string, object&gt;.</returns>
/// <remarks><seealso href="https://redis.io/commands/graph.slowlog"/></remarks>
Task<List<List<string>>> SlowlogAsync(string graphName);
}
Expand Down
2 changes: 1 addition & 1 deletion src/NRedisStack/Search/AggregationResult.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ internal AggregationResult(RedisResult result, long cursorId = -1)
/// <summary>
/// takes a Redis multi-bulk array represented by a RedisResult[] and recursively processes its elements.
/// For each element in the array, it checks if it's another multi-bulk array, and if so, it recursively calls itself.
/// If the element is not a multi-bulk array, it's added directly to a List<object>.
/// If the element is not a multi-bulk array, it's added directly to a List&lt;object&gt;.
/// The method returns a nested list structure, reflecting the hierarchy of the original multi-bulk array,
/// with each element either being a direct value or a nested list.
/// </summary>
Expand Down
4 changes: 2 additions & 2 deletions src/NRedisStack/Tdigest/ITdigestCommands.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ public interface ITdigestCommands
bool Add(RedisKey key, params double[] values);

/// <summary>
/// Estimate the fraction of all observations added which are <= value.
/// Estimate the fraction of all observations added which are &lt;= value.
/// </summary>
/// <param name="key">The name of the sketch.</param>
/// <param name="values">upper limit of observation value.</param>
/// <returns>double-reply - estimation of the fraction of all observations added which are <= value</returns>
/// <returns>double-reply - estimation of the fraction of all observations added which are &lt;= value</returns>
/// <remarks><seealso href="https://redis.io/commands/tdigest.cdf"/></remarks>
double[] CDF(RedisKey key, params double[] values);

Expand Down
4 changes: 2 additions & 2 deletions src/NRedisStack/Tdigest/ITdigestCommandsAsync.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ public interface ITdigestCommandsAsync
Task<bool> AddAsync(RedisKey key, params double[] values);

/// <summary>
/// Estimate the fraction of all observations added which are <= value.
/// Estimate the fraction of all observations added which are &lt;= value.
/// </summary>
/// <param name="key">The name of the sketch.</param>
/// <param name="values">upper limit of observation value.</param>
/// <returns>double-reply - estimation of the fraction of all observations added which are <= value</returns>
/// <returns>double-reply - estimation of the fraction of all observations added which are &lt;= value</returns>
/// <remarks><seealso href="https://redis.io/commands/tdigest.cdf"/></remarks>
Task<double[]> CDFAsync(RedisKey key, params double[] values);

Expand Down
2 changes: 1 addition & 1 deletion tests/Test.proj
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
<ItemGroup>
<ProjectReference Include="**\*.*proj" />
</ItemGroup>
</Project>
</Project>
Loading