Fix library versioning: reading version from assembly #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayim
changed the title
|
@shacharPash after this let's make sure a release is all well and good (.10.1). Similarly in parallel to CSC can you take a look at #195 |
shacharPash
reviewed
Oct 22, 2023
src/NRedisStack/Auxiliary.cs
Outdated
| // Load the .csproj file. | ||
| var csprojDocument = XDocument.Load(csprojFilePath); | ||
| return csprojDocument; | ||
| return typeof(NRedisStack.Auxiliary).Assembly.GetName().Version.ToString(); |
There was a problem hiding this comment.
@slorello89 Thanks for noticing, I actually already fixed it and probably deleted it by mistake.
This line specifically will return a version of type: x.y.z.x no?
Because I want it to be x.y.z, without the fourth digit.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 94.06% 94.05% -0.01%
==========================================
Files 85 85
Lines 5186 5178 -8
Branches 488 488
==========================================
- Hits 4878 4870 -8
Misses 181 181
Partials 127 127
☔ View full report in Codecov by Sentry. |
shacharPash
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where NRedisStack was trying to read NRedisStack version out of the csproj file. What this means in practice is that any time anyone uses the nuget package for anything related to NRedisStack (any module commands), you would see an error e.g.:
The proper way to pull the version is by using the assembly. Produces a traditional Microsoft version number (e.g. 0.10.1.0) - Major.Minor.Build.Revision - that should be fine though.