Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating CODEOWNERS for documentation #192

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Creating CODEOWNERS for documentation #192

merged 1 commit into from
Oct 12, 2023

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Oct 9, 2023

This pull request uses the CODEOWNERS mechanism to define a dedicated owner for the redis.io examples. Ultimately, the people in this file should be able to override CI based on possible false positives in tests, if they are unrelated.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3d639ce) 94.06% compared to head (acf1c65) 94.06%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   94.06%   94.06%           
=======================================
  Files          82       82           
  Lines        5109     5109           
  Branches      483      483           
=======================================
  Hits         4806     4806           
  Misses        176      176           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shacharPash
Copy link
Contributor

I wanted to see the changes and saw this error:
Unknown owner on line 1: make sure @dmaier-redislabs exists and has write access to the repository
tests/doc/* @dmaier-redislabs

@shacharPash shacharPash merged commit c07ceaf into master Oct 12, 2023
@shacharPash shacharPash deleted the ck-example-CO branch October 12, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants