Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean warnings #184

Merged
merged 55 commits into from
Sep 27, 2023
Merged

Clean warnings #184

merged 55 commits into from
Sep 27, 2023

Conversation

shacharPash
Copy link
Contributor

Fix #116

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (ac897cc) 94.07% compared to head (2c5dab6) 80.70%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #184       +/-   ##
===========================================
- Coverage   94.07%   80.70%   -13.38%     
===========================================
  Files          82       82               
  Lines        5116     5109        -7     
  Branches      483      483               
===========================================
- Hits         4813     4123      -690     
- Misses        176      886      +710     
+ Partials      127      100       -27     
Files Coverage Δ
src/NRedisStack/Gears/GearsCommandBuilder.cs 98.14% <100.00%> (ø)
src/NRedisStack/Gears/GearsCommands.cs 100.00% <100.00%> (ø)
src/NRedisStack/Gears/GearsCommandsAsync.cs 100.00% <100.00%> (ø)
src/NRedisStack/Graph/GraphCacheList.cs 0.00% <ø> (-97.37%) ⬇️
src/NRedisStack/Graph/GraphCommands.cs 0.00% <ø> (-94.45%) ⬇️
src/NRedisStack/Graph/GraphCommandsAsync.cs 0.00% <ø> (-94.45%) ⬇️
src/NRedisStack/Json/JsonCommands.cs 88.27% <100.00%> (ø)
src/NRedisStack/Json/JsonCommandsAsync.cs 88.27% <100.00%> (ø)
src/NRedisStack/ModulePrefixes.cs 88.88% <ø> (-11.12%) ⬇️
src/NRedisStack/Pipeline.cs 93.33% <ø> (-6.67%) ⬇️
... and 39 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shacharPash shacharPash marked this pull request as ready for review September 27, 2023 08:59
@shacharPash shacharPash merged commit cfeb817 into master Sep 27, 2023
@shacharPash shacharPash deleted the CleanWarnings branch September 27, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean warnings
3 participants