Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-70884) test: drop removed SCSI passthrough feature #313

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

mrc0mmand
Copy link
Member

@mrc0mmand mrc0mmand commented Jan 21, 2025

This feature has been deprecated since QEMU 5.0 and finally removed in QEMU 9.1 [0] which now causes issues when running the storage tests on latest Arch:

------ testcase_long_sysfs_path: BEGIN ------
...
qemu-system-x86_64: -device virtio-blk-pci,drive=drive0,scsi=off,bus=pci_bridge25: Property 'virtio-blk-pci.scsi' not found E: qemu failed with exit code 1

[0] qemu/qemu@a271b8d

(cherry picked from commit cd57920fbf6a8f7769a82cfc9bebc12965de0199)

Related: RHEL-70884

This feature has been deprecated since QEMU 5.0 and finally removed in
QEMU 9.1 [0] which now causes issues when running the storage tests on
latest Arch:

------ testcase_long_sysfs_path: BEGIN ------
...
qemu-system-x86_64: -device virtio-blk-pci,drive=drive0,scsi=off,bus=pci_bridge25: Property 'virtio-blk-pci.scsi' not found
E: qemu failed with exit code 1

[0] qemu/qemu@a271b8d

(cherry picked from commit cd57920fbf6a8f7769a82cfc9bebc12965de0199)

Related: RHEL-70884
@github-actions github-actions bot changed the title test: drop removed SCSI passthrough feature (RHEL-70884) test: drop removed SCSI passthrough feature Jan 21, 2025
@github-actions github-actions bot added pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Jan 21, 2025
Copy link

github-actions bot commented Jan 21, 2025

Commit validation

Tracker - RHEL-70884

The following commits meet all requirements

commit upstream
f3dbcae - test: drop removed SCSI passthrough feature systemd/systemd@cd57920

Tracker validation

Success

🟢 Tracker RHEL-70884 has set desired product: rhel-9.6
🟢 Tracker RHEL-70884 has set desired component: systemd
🟢 Tracker RHEL-70884 has been approved
🟢 Tracker RHEL-70884 has set severity


Pull Request validation

Success

🟡 CI - Waived
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved


Auto Merge

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟠 Pull Request meet requirements, mergeable_state is unstable
🟢 Pull Request has correct target branch main
🟢 Pull Request was merged

Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the pr/needs-review Formerly needs-review label Jan 21, 2025
@mrc0mmand
Copy link
Member Author

The mkosi CI fail is unrelated.

@github-actions github-actions bot removed the pr/needs-ci Formerly needs-ci label Jan 22, 2025
@github-actions github-actions bot merged commit 6f792eb into redhat-plumbers:main Jan 22, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants