Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove networktype var #595

Merged

Conversation

akrzos
Copy link
Member

@akrzos akrzos commented Jan 24, 2025

No description provided.

Copy link

openshift-ci bot commented Jan 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrzos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akrzos
Copy link
Member Author

akrzos commented Jan 27, 2025

/test deploy-5nodes

@akrzos akrzos marked this pull request as ready for review January 27, 2025 15:00
@akrzos akrzos removed the request for review from jtaleric January 27, 2025 15:01
@akrzos
Copy link
Member Author

akrzos commented Jan 27, 2025

@josecastillolema With this, I believe you will have to remove the var from the CI and CPT all.yml

@josecastillolema
Copy link
Collaborator

Thanks for the heads-up @akrzos !
We should delete it from the all.yml for hygiene or because it's gonna break new deployments?
If its the latter let's bake a new release once it gets merged.

@josecastillolema
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 27, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 97bbbdf into redhat-performance:main Jan 27, 2025
2 checks passed
@akrzos
Copy link
Member Author

akrzos commented Jan 27, 2025

Thanks for the heads-up @akrzos ! We should delete it from the all.yml for hygiene or because it's gonna break new deployments? If its the latter let's bake a new release once it gets merged.

There is no breakage, the CI successfully deployed. Any extra vars not in use won't break Ansible, but we should clean it up since it could cause confusion for anyone who hasn't been following the changes in jetlag.

@akrzos akrzos deleted the remove_var_networktype branch January 27, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants